Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦️ Update LFS packaging #21

Merged
merged 8 commits into from
Jun 28, 2023
Merged

📦️ Update LFS packaging #21

merged 8 commits into from
Jun 28, 2023

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Jun 27, 2023

Fixes

Description

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the main branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation).
  • I tried running the project in my fork and locally (
    $ docker pull ghcr.io/fcp-indi/c-pac_templates:lfs-update87459a0
    $ docker run --rm -it --entrypoint /bin/bash --user 0 ghcr.io/fcp-indi/c-pac_templates:lfs-update87459a0
    # apt-get update && apt-get install -y python3-pip
    # pip3 install ipython nibabel
    # ipython
    >>> import nibabel as nib
    >>> img = nib.load('/cpac_templates/rois_3mm.nii.gz')
    >>> print(img.header)
    <class 'nibabel.nifti1.Nifti1Header'> object
    ) and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy added bug Something isn't working enhancement New feature or request labels Jun 27, 2023
@shnizzedy shnizzedy merged commit cc23e65 into main Jun 28, 2023
@shnizzedy shnizzedy deleted the lfs/update branch June 28, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants