Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Smith[…]desc-thresh3_mask.nii.gz #5

Merged
merged 3 commits into from
Nov 19, 2021
Merged

✨ Add Smith[…]desc-thresh3_mask.nii.gz #5

merged 3 commits into from
Nov 19, 2021

Conversation

shnizzedy
Copy link
Member

Fixes

Related to #1 by @shnizzedy, @milham01 and @engfranco

Description

Adds a binary mask image at Z = 3 created from "10 well-matched maps from these, as shown in PNAS paper" from Correspondence between BrainMap and Resting-FMRI ICA components1

Screenshots

z.3.mp4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the main branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Footnotes

  1. Smith, Stephen M et al. “Correspondence of the brain's functional architecture during activation and rest.” Proceedings of the National Academy of Sciences of the United States of America vol. 106,31 (2009): 13040-5. doi:10.1073/pnas.0905267106

shnizzedy and others added 2 commits October 15, 2021 13:49
Co-authored-by: Mike Milham <[email protected]>
Co-authored-by: Alex Franco <[email protected]>
Co-authored-by: Greg Kiar <[email protected]>
@shnizzedy shnizzedy added enhancement New feature or request Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 15, 2021
@shnizzedy
Copy link
Member Author

shnizzedy commented Oct 15, 2021

I don't love that I haven't finished the row for this entry in the table in the README

Atlas Name # Regions Symmetrical? Hierarchical? Labelled? Generation Method Average Vol/Region Native coordinate space Description Reference Publication Year of Origin File Source/Download URL
Smith desc-thresh3 10 scripts/threshold_mask.py Smith (above) thresholded at Z = 3 as in Fig 1 doi:10.1073/pnas.0905267106 2009

but I figure most of that will be the same as the row above it once #2 is done

@shnizzedy
Copy link
Member Author

I'm also not quite confident that I got the BIDS filename quite right:

Smith_space-MNI152NLin6_res-3x3x3_desc-thresh3_mask.nii.gz ?

@shnizzedy shnizzedy added the RBC https://github.com/PennLINC/RBC label Oct 26, 2021
@sgiavasis
Copy link
Contributor

I'm also not quite confident that I got the BIDS filename quite right:

Smith_space-MNI152NLin6_res-3x3x3_desc-thresh3_mask.nii.gz ?

As long as it gets pulled into the engine properly and the resulting output files are named properly, it's good.

@shnizzedy shnizzedy merged commit 19ae128 into main Nov 19, 2021
@shnizzedy shnizzedy deleted the thresh/3 branch November 19, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest https://hacktoberfest.digitalocean.com/ RBC https://github.com/PennLINC/RBC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants