Responsive Web Design Fixes: Global Components and Home #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demenech
requested changes
Dec 7, 2023
components/home/main/News.tsx
Outdated
| @@ -45,146 +45,157 @@ export default function News() { | |||
| <p className="mt-3 mb-6 text-center text-base text-gray font-normal"> | |||
| {t('hm-p-news-text')} | |||
| </p> | |||
| <div className="container mx-auto flex flex-wrap h-96"> | |||
|
|
|||
| <div className="grid grid-cols-1 md:grid-rows-2 lg:grid-rows-1 lg:grid-cols-3 gap-4"> | |||
There was a problem hiding this comment.
I would suggest that you add a max-width for this section, otherwise it looks bad on 2k and 4k resolutions
components/home/main/OpenData101.tsx
Outdated
| @@ -10,18 +10,22 @@ export default function OpenData101(props) { | |||
| } | |||
|
|
|||
| return ( | |||
| <div className="relative h-fit"> | |||
| <div className="relative h-fit mb-[70px] sm:mb-10"> | |||
There was a problem hiding this comment.
same as for news, I think we need a max-w on this section
added 2 commits
December 7, 2023 17:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #139
Changes:
Global Sections and Components
Pages