Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Fixes: Global Components and Pages #148

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

willy1989cv
Copy link
Collaborator

Changes

  • Global Sections and Components
    • Gray color contrast
    • ScrollIndicator empty button
    • Data 101 title and "go back to top" color contrast: changed from #54CA59 to #0E5D15. the least dark accepted
  • Home
    • Topics card color contrast
  • Datasets
    • Search missing form label
    • Dataset description color contrast: Darken the color. from #7C7C7C to #545454
    • Redundant alternative texts
    • Nearby images has the same alternative text
    • Developer experience theme changed to githubGist
  • Dataset Detail Page
    • Share Link empty
    • Dataset info (created, updated, ...) color contrast: #787878 to #595959
    • Share, cite, rate color contrast
    • Dataset categories color contrast
    • Resource download, rows and columns color contrast
    • Images with same alt text
    • Multiple h2
  • Build Your Data.
    • Data description color contrast
    • Select Missing Labels
    • Imgs with same alt text
    • Possible Heading

@demenech demenech self-requested a review December 18, 2023 23:19
Copy link
Collaborator

@demenech demenech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

IMO you should limit the height of the overlay so that it won't darken the whole image. I suggest making the overlay an absolutely positioned div with a bottom-to-top gradient.

image

Except for that and the conflict, LGTM.

Copy link
Collaborator

@demenech demenech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@demenech demenech merged commit 4fe37aa into main Dec 19, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants