Fix action space check #331
Conversation
pbrubeck
force-pushed
the
pbrubeck/fix/action-space-check
branch
from
4e6729b to
59820fc
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/action-space-check
branch
from
59820fc to
f2a9c8a
Compare
|
This ruff thing is ridiculous |
You can add: ruff enforces code style simeq to black, which makes life easier for contributors as they can run ruff format and ruff check to ensure that everyone uses a consistent code style. This also reduces the diff’s for each PR (except when ruff adds new rules). see for instance #330 |
| @@ -159,29 +157,36 @@ def __hash__(self): | |||
|
|
|||
| def _check_function_spaces(left, right): | |||
There was a problem hiding this comment.
Dear code reviewers,
Please ignore the rest of the diff, that's just ruff.
Only take a look at this function.
Thank you.
|
@jorgensd FeniCSx CI fails, but I suspect it is for an unrelated reason? |
@finsberg, it seems like you missed a test with your latest PR: |
| @@ -9,15 +9,14 @@ | |||
|
|
|||
| from itertools import chain | |||
|
|
|||
| from ufl import matrix # noqa 401 | |||
There was a problem hiding this comment.
ufl.matrix wants to be imported before ufl.action. Also note that ufl.action.Action is the first class to be imported within __init__.py
Fix action space check ruff unsafe ruff symmetric space check fix import conflict Fix action space check (FEniCS#331) * Fix action space check * ruff * unsafe ruff * symmetric space check * fix import conflict remove apply_default_restrictions() (FEniCS#329) * ruff==0.8.0 * remove apply_default_restrictions() --------- Co-authored-by: Matthew Scroggs <[email protected]>
The space check in
actionwas not quite right, it is hard to tell exactly why. Previously it only passed becauseV == V.dual()in Firedrake.This PR removes the need to check specific types of the arguments and handles them in a more symmetric way.