(Experimental) Update message properties via Hostapi #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HostAPI. This would need expanding to other message types, not personally happy with all the setter repetition from Description class, so may need thought to rework.
Robadob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental branch testing something @AshurstJ thought was already possible.
Only adds Spatial3D support currently. It appears to work, but not had any thorough testing.
Easier than expected (in this case of spatial messages and bucket?), as
CUDAMessagealready has the rebuild PBM flag method.Not really a fan of the repetition of all the
Msg::Descriptionmethods on theMsg::HostAPIobject though. Can't simply provide desc, as this would expose the variable methods and wouldn't trigger the flags which need to be set on change. Some kind of shared class?/multi inheritance?Video demo with circles: https://youtu.be/GZV1l5d9FEw
(Not actually necessary here tbh, if I made the radius smaller than bigger old PBM would work, just be inefficient. But you can see the model speed up when radius drops so seems to be working as expected.)
CI failing because I called the nested class
HostAPI, needs a more distinct name I guess.Relates #710