Update to new frontend #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… backwards compatible.
Still doesn't simulate correctly.
biananino
force-pushed
the
update-to-new-frontend
branch
from
f0b7fe5 to
1bef7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted for your approval, like #57, this pull request attempts to update OMChemSim to the current modelica specification, so it can run in OpenModelica. Unlike #57 this pull request updates all models and examples.
Changes consist mostly of:
Other changes include changing some names that were left behind in Name change #28, fixing some impactful typos and slightly rewriting some parts when needed.
This pull request fixes Problems installing OMChemSim #56 and OMChemSim is in violation of the modelica specification. #58