Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Feat/magic swerve #5

Closed
wants to merge 37 commits into from
Closed

Feat/magic swerve #5

wants to merge 37 commits into from

Conversation

Kredcool
Copy link
Contributor

Don't merge without permission from @Kredcool

@Kredcool Kredcool self-assigned this Jan 13, 2024
Copy link
Member

@KenwoodFox KenwoodFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review #6 a lot of fixes are in there.

self.sd.putNumber("Swerve/RL", self.rearLeft.desiredState.angle.degrees())
self.sd.putNumber("Swerve/RR", self.rearRight.desiredState.angle.degrees())

logging.info(f"FR Swerve module setpoint {self.frontRight.desiredState.angle.degrees()}, actual is {self.frontRight.getPosition().angle.degrees()}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[blackfmt] reported by reviewdog 🐶

Suggested change
logging.info(f"FR Swerve module setpoint {self.frontRight.desiredState.angle.degrees()}, actual is {self.frontRight.getPosition().angle.degrees()}")
logging.info(
f"FR Swerve module setpoint {self.frontRight.desiredState.angle.degrees()}, actual is {self.frontRight.getPosition().angle.degrees()}"
)

@KenwoodFox
Copy link
Member

So we're prolly not gonna merge this ever, but don't close this PR, just leave it stale.

@Kredcool Kredcool closed this Jan 25, 2024
@Kredcool Kredcool deleted the feat/magicSwerve branch January 28, 2024 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants