Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Pivot/commands template #7

Merged
merged 61 commits into from
Jan 27, 2024
Merged

Pivot/commands template #7

merged 61 commits into from
Jan 27, 2024

Conversation

KenwoodFox
Copy link
Member

Works! Command v2 template, @Kredcool can decide to take inspiration from this or switch back to commands. I would prefer magicbot but.. the numbers don't lie, atm this code works better than our magic code.

kredcool and others added 30 commits January 10, 2024 16:24
… it should********* be gone by the end of the weekend if robotpy people get themselves in gear. TLDR added git submodule to fix being ahead of robotpy
@KenwoodFox
Copy link
Member Author

Ok, a couple big things need to be gone over here.

  • Switching from the magicbot to the commandsv2 template, this is the biggest and most obvious. We'll want to preserve our config for the mike modules (Remember they are similar to the max modules but constructed differently)
  • Poses must be updated, and most likely config changes must happen
  • Currently the tests are broken, if i manage to fix them I'll edit this comment
  • What happened with the pyproject.toml? Is this new for this season or have we just not seen it? There are things we'll need to modify with our old system of robot_requirements.txt

KenwoodFox and others added 6 commits January 21, 2024 15:18
A real fix will come from upstream (eventually, no timeframe from robotpy)
…ons for the angular offsets were what was making the wheels wonky. So I set them all to 0 and now it works. Also updated the distance between modules and reassigned Spark IDs because they were wrong and dumb
@Kredcool Kredcool marked this pull request as ready for review January 25, 2024 22:03
@KenwoodFox
Copy link
Member Author

@Kredcool Why is this not merged? Is it done? if its done... merge it! @NotSimon5673 is already having dep issues! Dont leave PRs to get massive!

@Kredcool Kredcool added this pull request to the merge queue Jan 27, 2024
Merged via the queue into main with commit 9b5326e Jan 27, 2024
4 checks passed
@Kredcool Kredcool deleted the pivot/commands_template branch January 28, 2024 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants