This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged. this is just the init
… it should********* be gone by the end of the weekend if robotpy people get themselves in gear. TLDR added git submodule to fix being ahead of robotpy
Ok, a couple big things need to be gone over here.
|
A real fix will come from upstream (eventually, no timeframe from robotpy)
…ons for the angular offsets were what was making the wheels wonky. So I set them all to 0 and now it works. Also updated the distance between modules and reassigned Spark IDs because they were wrong and dumb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Kredcool Why is this not merged? Is it done? if its done... merge it! @NotSimon5673 is already having dep issues! Dont leave PRs to get massive! |
Kredcool
approved these changes
Jan 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works! Command v2 template, @Kredcool can decide to take inspiration from this or switch back to commands. I would prefer magicbot but.. the numbers don't lie, atm this code works better than our magic code.