This repository has been archived by the owner on Nov 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Vision and Autonomous: Boilerplate FRCVision #22
Open
KhanSimeoni
wants to merge
49
commits into
main
Choose a base branch
from
feature/aivision
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… most of drivetrain. I added the comments that wern't covered by yours - Khan, to Joe
KhanSimeoni
added
the
new subsystem
Entirely new subsytem or rewrite/large addon to existing subsystem.
label
Feb 12, 2022
KenwoodFox
suggested changes
Feb 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id like to see more with networktables before this gets merged.
Co-authored-by: KenwoodFox <[email protected]> This has some issues we need to work out.
This adds some additional print statements and a test button command to make testing a bit easier.
KenwoodFox
suggested changes
Feb 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorta getting there.
…apidReact into feature/aivision
Ill fix this soon |
KenwoodFox
suggested changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KhanSimeoni i saw you changing all that code, did you push it up?
…apidReact into feature/aivision
KenwoodFox
reviewed
Mar 3, 2022
Comment on lines
+104
to
+107
commands2.button.JoystickButton(self.driverController, 5).whenPressed( | ||
LimeAuto(self.drivetrain) | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
new subsystem
Entirely new subsytem or rewrite/large addon to existing subsystem.
pending test
might be solved but it needs to be tested.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inital code for the FRC vision system.