Differant way to construct Encoders #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nadezaxer I have removed the EncoderSim completely from the subsystem and it seems to still work. There seems to be a link created when the encoderSim(encoder) is created that any encoderSim.setDistance() reflex in the encoder. I would love to see you take a look at the current state of my branch. I will also clone your branch. I know there were some better ways to construct the subsystem but is NOT a convention I have ever used. |
|
I probably should have NOT BEEN actively pushing to that Branch after the PR. Its also a bit confusing because your @Nadezaxer forked and branch has the same "Name" as mine that live on the 4607 trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3
Would this be a better way to format simulation object?