Removing hints #523
Merged
Removing hints #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msprotz
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Great. Hints have always been a band-aid and I'll be happy to see them go. A few thoughts:
- there is no hints-refresh job on this repo, no need to worry about that
- the proofs for these files were never substantial, and we never reached the size (like in HACL*) where the files would start triggering unreliable z3 behavior, so hints were never crucial for verification
- speaking of HACL*, does the repo verify without hints and with the new option? if so, I'd be happy to take a PR there
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following F* PRs FStarLang/FStar#3440 and FStarLang/FStar#3680
This PR removes all hints files from the Karamel repo and updates the Makefiles to use the
--ext context_pruningflag instead.With this flag, F* prunes away SMT assertions that cannot be triggered by symbols in the query, making hints/unsat-core replay mostly unnecessary.
We have been using this feature in the F*, Pulse, EverParse, and other related repos for a few months now, and recently removed all hints from the F* repo.
Could this be a simplification for Karamel too? If so, we could also remove the hint-refresh CI jobs.