Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in the detector data translation in euxfel backend #152

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

egorsobolev
Copy link
Collaborator

This fixes issues with detector data translation in euxfel backend:

  • convert cells mask to indices, because it is used in numpy.take
  • terminate translation if cellId dataset is empty

Also removes old commented code.

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (945c95a) 22.53% compared to head (697cad9) 22.52%.

Files Patch % Lines
hummingbird/backend/euxfel.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   22.53%   22.52%   -0.01%     
==========================================
  Files          89       89              
  Lines        7500     7502       +2     
==========================================
  Hits         1690     1690              
- Misses       5810     5812       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FilipeMaia FilipeMaia merged commit 92f8772 into master Feb 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants