New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed and improved around query parameters #2

Open

pokehanai wants to merge 3 commits into FastFeed:master from pokelabo:feature/parameter

pokehanai commented Jan 21, 2015

Hi,

There ware some issues around query parameters, like:

Url class did not care of url encoded string.
getParameters() did return null (instead of array) if there was no query parameters.
getParameter() did possibly cause PHP's warning if specified parameter did not exist.

So I made some patches. It also includes an additional feature.

added $defaultValue parameter to getParameter().

pokehanai added 3 commits

January 21, 2015 14:29


          FIX: getParameters() should return array always.

337913b

getParameters() did return null if no query parameters passed to the
constructor.


          FIX: parameters should be url-decoded.

dc52a03


          Now getParameter() has $defaultValue for non-exist param key.

04a9a33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet