Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS installer - Add multilanguage strings #806

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

bovirus
Copy link
Contributor

@bovirus bovirus commented Jan 21, 2025

@grulja

Please check installer script.
Added multilanguage strings (original messagebox strings were hardcoded in English).
Note: in original nsi script was declared "UninstLogMissing" variable that should contain text string but was not defined.

@grulja
Copy link
Collaborator

grulja commented Feb 4, 2025

We will also need these strings to be added to the pot file and then have a way how to get the translations from po files back to the installer.

@bovirus
Copy link
Contributor Author

bovirus commented Feb 4, 2025

@grulja
I believe that for now you can use the strings in NSIS script.
In the futire if you will find how to use in po and get in NSIS you can switch to this method.

Copy link
Collaborator

@grulja grulja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you in that case add the missing UninstLogMissing? It can say something like "Unable to uninstall ${APPNAME}, the ${UninstLog} file is missing.

@bovirus
Copy link
Contributor Author

bovirus commented Feb 4, 2025

@grulja

It seems that I already fixed the issues.
All "Messagebox" reference point to a string that is in lnSIS script.
No one UninstLogMissing reference in the script.

@grulja
Copy link
Collaborator

grulja commented Feb 4, 2025

@grulja

It seems that I already fixed the issues. All "Messagebox" reference point to a string that is in lnSIS script. No one UninstLogMissing reference in the script.

You are right, I misunderstood the code in the script. I thought it's a dialog that says it fails to uninstall FMW, because the file is missing. Looks good to me now.

@grulja grulja merged commit 24f6b4a into FedoraQt:main Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants