Skip to content

Commit

Permalink
BUG/MINOR: http-ana: Disable fast-fwd for unfinished req waiting for …
Browse files Browse the repository at this point in the history
…upgrade

If a request is waiting for a protocol upgrade but it is not finished, the
data fast-forwarding is disabled. Otherwise, the request analyzers will miss
the end of the message.

This case is possible since the commit 01fb1a54 ("BUG/MEDIUM: mux-h1/mux-h2:
Reject upgrades with payload on H2 side only"). Indeed, before, a protocol
upgrade was not allowed for request with payload. But it is now possible and
this comes with a side-effect. It is not really satisfying but for now there
is no other way to sync the muxes and the applicative stream. It seems to be
a reasonnable fix for now, waiting for a deeper refactoring.

This patch must be backported with the commit above.

(cherry picked from commit cea1379)
Signed-off-by: Christopher Faulet <[email protected]>
  • Loading branch information
capflam committed Oct 2, 2024
1 parent f4441c8 commit 6d98108
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/http_ana.c
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,8 @@ int http_request_forward_body(struct stream *s, struct channel *req, int an_bit)
}
else {
c_adv(req, htx->data - co_data(req));
if ((global.tune.options & GTUNE_USE_FAST_FWD) && (msg->flags & HTTP_MSGF_XFER_LEN))
if ((global.tune.options & GTUNE_USE_FAST_FWD) && (msg->flags & HTTP_MSGF_XFER_LEN) &&
(!(msg->flags & HTTP_MSGF_CONN_UPG) || (htx->flags & HTX_FL_EOM)))
channel_htx_forward_forever(req, htx);
}

Expand Down

0 comments on commit 6d98108

Please sign in to comment.