MINOR: mux-h2/traces: add a missing trace on negative initial window …

…size When a negative initial windows size is reported, we're going to close the connection, so it's important to report a trace to explain why! This should be backported at least to 3.1 and possibly 3.0 (adapting the context since there's no glitches there). (cherry picked from commit 86823c8) Signed-off-by: Willy Tarreau <[email protected]> (cherry picked from commit 35bb79b797b85f8b89c87b8b925bc50f6f25865c) Signed-off-by: Christopher Faulet <[email protected]>
FireBurn · Dec 11, 2024 · a016c73 · a016c73
1 parent ffdd10f
commit a016c73
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/mux_h2.c b/src/mux_h2.c
@@ -2386,6 +2386,7 @@ static int h2c_handle_settings(struct h2c *h2c)
 			if (arg < 0) { // RFC7540#6.5.2
 				error = H2_ERR_FLOW_CONTROL_ERROR;
 				h2c_report_glitch(h2c, 1);
+				TRACE_STATE("negative INITIAL_WINDOW_SIZE", H2_EV_RX_FRAME|H2_EV_RX_SETTINGS|H2_EV_H2C_ERR|H2_EV_PROTO_ERR, h2c->conn);
 				goto fail;
 			}
 			/* Let's count a glitch here in case of a reduction