Skip to content

Commit

Permalink
MINOR: trace: support all source alias on -dt
Browse files Browse the repository at this point in the history
Command line argument -dt can be used to activate traces during startup.
Via its optional argument, it is possible to change settings for a
particular trace source. It is also possible to update every registered
sources by specifying an empty name.

Support the trace source alias "all". This is an alternative to the
empty name to update every sources.
  • Loading branch information
a-denoyelle committed Jan 10, 2025
1 parent a50dd07 commit a2c0c45
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -1016,10 +1016,11 @@ int trace_parse_cmd(const char *arg_src, char **errmsg)
"A list can be specified as argument to configure several trace sources with comma as separator.\n"
"Each entry can contains the trace name, a log level and a verbosity using colon as separator.\n"
"Every fields are optional and can be left empty, or with a colon to specify the next one.\n\n"
"An empty name will activate all registered sources.\n"
"An empty name or the alias 'all' will activate all registered sources.\n"
"Verbosity cannot be configured in this case except 'quiet' as their values are specific to each source.\n\n"
"Examples:\n"
"-dt activate every sources on error level\n"
"-dt all:user activate every sources on user level\n"
"-dt h1 activate HTTP/1 traces on error level\n"
"-dt h2:data activate HTTP/2 traces on data level\n"
"-dt quic::clean,qmux::minimal\n activate both QUIC transport and MUX traces on error level with their custom verbosity\n");
Expand Down Expand Up @@ -1060,7 +1061,7 @@ int trace_parse_cmd(const char *arg_src, char **errmsg)
str = NULL;
}

if (strlen(name)) {
if (strlen(name) && strcmp(name, "all") != 0) {
src = trace_find_source(name);
if (!src) {
memprintf(errmsg, "unknown trace source '%s'", name);
Expand Down

0 comments on commit a2c0c45

Please sign in to comment.