Skip to content

Commit

Permalink
Fix for #33
Browse files Browse the repository at this point in the history
  • Loading branch information
pcisar committed Nov 25, 2023
1 parent 99ef4ea commit 7e794a6
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [1.10.1] - Unreleased

### Fixed

- #33 - SIGABRT on interface detach.

## [1.10.0] - 2023-10-03

### Fixed
Expand Down
15 changes: 8 additions & 7 deletions src/firebird/driver/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -1176,9 +1176,10 @@ def ping(self) -> None:
self._check()
def detach(self) -> None:
"Replaces `isc_detach_database()`. On success releases interface."
self.vtable.deprecatedDetach(self, self.status)
self._check()
self._refcnt -= 1
if self._refcnt:
self.vtable.deprecatedDetach(self, self.status)
self._check()
self._refcnt -= 1
def drop_database(self) -> None:
"Replaces `isc_drop_database()`. On success releases interface."
self.vtable.deprecatedDropDatabase(self, self.status)
Expand Down Expand Up @@ -1223,7 +1224,7 @@ def create_batch(self, transaction: iTransaction, stmt: str, dialect: int,

# IAttachment(5) : IAttachment(4)
class iAttachment(iAttachment_v4):
"Class that wraps IAttachment v4 interface for use from Python"
"Class that wraps IAttachment v5 interface for use from Python"
VERSION = 5
def detach(self) -> None:
"Replaces `isc_detach_database()`. On success releases interface."
Expand All @@ -1238,7 +1239,7 @@ def drop_database(self) -> None:

# IService(3) : ReferenceCounted
class iService_v3(iReferenceCounted):
"Class that wraps IService interface for use from Python"
"Class that wraps IService v3 interface for use from Python"
VERSION = 3
def detach(self) -> None:
"""Close attachment to services manager, on success releases interface.
Expand All @@ -1262,7 +1263,7 @@ def start(self, spb: bytes) -> None:

# IService(4) : IService(3)
class iService_v4(iService_v3):
"Class that wraps IService interface for use from Python"
"Class that wraps IService v4 interface for use from Python"
VERSION = 4
def detach(self) -> None:
"""Close attachment to services manager, on success releases interface.
Expand All @@ -1274,7 +1275,7 @@ def detach(self) -> None:

# IService(5) : IService(4)
class iService(iService_v4):
"Class that wraps IService interface for use from Python"
"Class that wraps IService v5 interface for use from Python"
VERSION = 5
def cancel(self) -> None:
"""Cancel wait of current `query()` call. Supported only for embedded connections.
Expand Down

0 comments on commit 7e794a6

Please sign in to comment.