Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Setup error #437

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Fix a Setup error #437

merged 1 commit into from
Feb 8, 2025

Conversation

sgjzfzzf
Copy link
Contributor

@sgjzfzzf sgjzfzzf commented Feb 7, 2025

PR Category

User Experience

Type of Change

Bug Fix

Description

When I tried to install it with pip from Github with pip install git+https://github.com/FlagOpen/FlagGems.git, and then use it in my project, it reports an error FileNotFoundError: [Errno 2] No such file or directory: '**/.venv/lib/python3.10/site-packages/flag_gems/runtime/backend/_nvidia/tune_configs.yaml'. It's due to the Yaml files are not packaged correctly during building. Now I reset the package searching patterns, and it works. You can try it with pip install git+https://github.com/sgjzfzzf/FlagGems.git.

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

Signed-off-by: jinjieliu <[email protected]>
@StrongSpoon
Copy link
Collaborator

@Galaxy1458 please take a look.

@Galaxy1458
Copy link
Collaborator

Thanks for your contribution! At the same time, could you please provide us with your environment and the versions of torch, triton and python or any other useful information you think, so that we can better test, because this problem does not occur within the scope we have tested.

@sgjzfzzf
Copy link
Contributor Author

sgjzfzzf commented Feb 8, 2025

Thanks for your contribution! At the same time, could you please provide us with your environment and the versions of torch, triton and python or any other useful information you think, so that we can better test, because this problem does not occur within the scope we have tested.

python
Python 3.10.12 (main, Jan 17 2025, 14:35:34) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> import triton
>>> torch.__version__
'2.6.0+cu124'
>>> triton.__version__
'3.2.0'

This problem occurred when I tried to install flag_gems in a new virtual environment. I found that if it's installed with pip install -e . or from a pre-built environment, this problem won't happen. You can try to start with a purely new environment and install it with pip install . to replay it.

Copy link
Collaborator

@Galaxy1458 Galaxy1458 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Galaxy1458 Galaxy1458 merged commit 5aa3ab7 into FlagOpen:master Feb 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants