Implement warning dialog #3
Conversation
|
The current implementation is "base" for the warning dialog. I think it is better to update/add them in other pull requests. Would you review this when you have time? |
src/web/dialog.js
Outdated
| @@ -1,4 +1,68 @@ | |||
| let totalCheckboxCount = 0; | |||
| function parse(recipient) { | |||
There was a problem hiding this comment.
parse and RecipientClassifier are copied from .mjs files.
This is because adding
<script type="module" src="recipient-classifier.mjs"></script>
<script type="module" src="recipient-parser.mjs"></script>
to dialog.html raises an error like below.
Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/plain". Strict MIME type checking is enforced for module scripts per HTML spec.
I think we should fix web server implementation so as to specify "javascript", but I think it is better to fix it in another PR in order to narrow the scope of modification.
There was a problem hiding this comment.
Fixed to use .mjs files.
We should merge #4 before this PR in order to work this correctly.
| @@ -8,12 +72,27 @@ Office.onReady(function () { | |||
| sendStatusToParent("ready"); | |||
| }); | |||
|
|
|||
| let counter = 0; | |||
| function generateTempId() { | |||
| return `fcm_temp_${counter++}_${Date.now()}`; | |||
There was a problem hiding this comment.
Or, simply using GUID and so on.
|
警告のアドレスの先頭にToやCcを追加しないといけないことに気付いたため、修正します。 |
|
追加しました。 |
HashidaTKS
force-pushed
the
implement-warning-dialog
branch
from
19b94c9 to
0e6a9d2
Compare
src/web/dialog.js
Outdated
| function generateTempId() { | ||
| return `fcm_temp_${counter++}_${Date.now()}`; | ||
| } | ||
|
|
||
| function sendStatusToParent(status) { | ||
| const messageObject = { status: status }; | ||
| const jsonMessage = JSON.stringify(messageObject); | ||
| Office.context.ui.messageParent(jsonMessage); | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
これらの「eslint-disable-next-line @typescript-eslint/no-unused-vars」は、関数が定義されているのに未使用だと判断されることによるlintのエラーを出さないようにするための物なのですが、今の状態でもまだ必要そうでしょうか？
There was a problem hiding this comment.
lintでエラーにならなかったのでスルーしてしまったのですが、確かに不要そうですので、確認の上、不要であれば削除します。
src/web/dialog.js
Outdated
| }; | ||
|
|
||
| function appendCheckboxes(target, groupedRecipients) { | ||
| for (const key in groupedRecipients) { |
There was a problem hiding this comment.
ここは
for (const [key, recipients] of Object.entries(groupedRecipients)) {
でいけそうに思いますが、どうでしょうか？
There was a problem hiding this comment.
for (const [key, recipients] of Object.entries(groupedRecipients)) {
を試して動かなかったような覚えがあるのですが、
for (const [key, recipients] in Object.entries(groupedRecipients)) {
としていて動かなかったのかもしれないため、確認します。
|
確認ありがとうございます。指摘事項に対応しました。 |
Add a warning dialog.
This patch based on #4, we should merge #4 beforehand in order to work this patch correctly.
Currently, it works only for trusted domains and untrusted domains, don't work for attachment or others.
The UI is implemented with Fluent UI for we components for style.