Introduce mechanism to localize messages #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashidaTKS
reviewed
Oct 16, 2024
HashidaTKS
requested changes
Oct 16, 2024
|
のように |
こちらのご指摘を承けて、langを動的に設定するように変更しました。 |
HashidaTKS
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Outlook-Office-Addin/src/web/app.html
Line 2 in c22816e
の<html lang="ja">も同様に直した方が良いと思います。（実際には国際化が不要なhtmlだとは思いますが）
以上の対応が完了したら、マージして大丈夫そうに思います。
|
app.htmlはHTMLにはメッセージがなかったのでスルーしていましたが、確かにここも影響を受ける部分なので修正しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a system to localize displayed messages.
Currently there is only "ja" locale.