Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add en and zh-CN locales #37

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Add en and zh-CN locales #37

merged 5 commits into from
Oct 17, 2024

Conversation

piroor
Copy link
Member

@piroor piroor commented Oct 16, 2024

T/O

@piroor piroor requested a review from HashidaTKS October 16, 2024 09:59
"confirmation_attachmentCheckboxLabel": "[附件] ${name}",

"newlyAddedDomainReconfirmation_caption": "警告!",
"_newlyAddedDomainReconfirmation_messageBefore": "There are recipients with domains not included in the recipients of the original message.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_がついているのは未翻訳だからでしょうか?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、その通りです。
翻訳時に未訳箇所がすぐ見付かるならば消してしまってもよいのですが、現在の所そのような仕組みがまだ用意されていないため、このように印を付けてみたという次第です。

@HashidaTKS
Copy link
Contributor

どれか一つのidのものだけで良いと思うのですが、l10nにおいて、languageの指定によって取得されるメッセージが変わることのユニットテストもあった方が良さそうに思いました。

@piroor
Copy link
Member Author

piroor commented Oct 17, 2024

l10nモジュールの自動テストを追加しました。

@piroor piroor requested a review from HashidaTKS October 17, 2024 04:56
Copy link
Contributor

@HashidaTKS HashidaTKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HashidaTKS HashidaTKS merged commit 16476d7 into main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants