Bundle external libraries #42
Merged
+100
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashidaTKS
commented
Jan 20, 2025
| @@ -9,7 +9,8 @@ | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
一見関係なさそうな差分もあるが、これは
npm install --save @microsoft/office-js
npm install --save @fluentui/web-components
で発生した差分なので、そのままコミットしている。
HashidaTKS
commented
Jan 20, 2025
| }, | ||
| { | ||
| from: "node_modules/@fluentui/web-components/dist/web-components.min.js", | ||
| to: "lib/fluentui/web-components/web-components.min.js", |
There was a problem hiding this comment.
node_modules/@fluentui/web-componentsにライセンスファイルが含まれていなかったのでコピーしていない。
| @@ -79,6 +79,26 @@ module.exports = async (env, options) => { | |||
| } | |||
| }, | |||
| }, | |||
| { | |||
| from: "node_modules/@microsoft/office-js/dist", | |||
There was a problem hiding this comment.
dist配下の全てをコピーしているので、すべての言語のモジュールをコピーしている。
それなりのサイズがあるので（80MB）、サポートする言語のみに限定しても良いかもしれない。
|
レビューをお願いします。 |
piroor
approved these changes
Jan 20, 2025
|
特に問題はなさそうに思いますのでマージします。ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle external libraries and use them instead of CDN.
Test