Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ItemSend instead of OnMessageSend #9

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Use ItemSend instead of OnMessageSend #9

merged 1 commit into from
Oct 1, 2024

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Oct 1, 2024

OnMessageSend warns if a handler takes time longer than 5 sec.

https://learn.microsoft.com/en-us/office/dev/add-ins/outlook/onmessagesend-onappointmentsend-events?tabs=windows#long-running-add-in-operations

On the other hand, ItemSend accept long time handlers. So we decided to use ItemSend.

Note that ItemSend always blocks to send a mail if there are some errors to load the addin.

OnMessageSend warns if a handler takes time longer than 5 sec.

https://learn.microsoft.com/en-us/office/dev/add-ins/outlook/onmessagesend-onappointmentsend-events?tabs=windows#long-running-add-in-operations

On the other hand, ItemSend accept long time handlers.
So we decided to use ItemSend.

Note that ItemSend always blocks to send mail if there are some errors to load addin.
@HashidaTKS HashidaTKS requested a review from piroor October 1, 2024 07:56
Copy link
Member

@piroor piroor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Looks good to merge.

@HashidaTKS HashidaTKS merged commit 1d7a85f into main Oct 1, 2024
1 check passed
@HashidaTKS
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants