Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Filter out empty string tags #876

Closed
wants to merge 651 commits into from
Closed

Filter out empty string tags #876

wants to merge 651 commits into from

Conversation

bendardenne
Copy link

@bendardenne bendardenne commented May 22, 2020 •
edited
Loading

Description

This is a minor change. Manually tested. See issue #875 for details.

Related Issue

#875

Motivation and Context

See linked issue.

How Has This Been Tested?

Manually tested. Tags automatically set by rtorrent upon torrent insertion are no longer overwritten by flood.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jplot
jplot previously approved these changes May 23, 2020
View reviewed changes
jesec and others added 29 commits November 1, 2020 22:11
@jesec
API: torrents: remove unneccessary activelyDownloading and activelyUp…
790f821 
…loading statuses
@jesec
API: torrents: calculate the Duration object in frontend
01dcf81
@jesec
client: remove unnecessary dayjs dependency
d186713
@jesec
server: qBittorrent: treat ETA >= 8640000 as infinity
fec96bc
@jesec
API: torrents: remove dhtStats, throttleMaxDownloadsDiv and throttleM…
08a9525 
…axUploadsDiv

No one knows what throttleMaxDownloadsDiv and throttleMaxUploadsDiv do. dhtStats
is not used. Let's remove them first to see how things go.
@jesec
i18n: new translations for Czech (#71)
0066ed7
@jesec
client: Sidebar: make the scrollbar non-intrusive
5bcce59
@jesec
server: replace explicit binds with arrow functions
017b9d1
@jesec
API: torrent: remove unused "paused" status
5e7e5f4
@jesec
server: clientGatewayService: keep refreshing connection status when …
abf9554 
…error occurred
@jesec
server: services: properly extends destroy function by calling super
48220af
@jesec
server: qBittorrent, rTorrent: properly hook functions to error handlers
dc1b939
@jesec
server: services: refrain from using unnecessary throws
600e22a
@jesec
API: client: remove connection test with new settings
4c24f56 
This simply won't work as we now support multiple clients. Each
client needs its own clientGatewayService which can only be
created by the user config.

Thus, let the form update user config directly.
@jesec
ClientConnectionInterruption: allow retrying with current settings
0002951
@jesec
server: clientActivityStream: ensure graceful transfer history fallback
ca32dcb
@jesec
NotificationsButton: display "No notification to display" message
3040304 
Bug: #73
@jesec
API: torrents: remove useless isMultiFile property
29c6fbe 
It is only used to determine whether to use .tar extension when
download is requested. However, server sent Content-Disposition
header which already tells the browser the filename and it is
more accurate.

As such, remove this useless property.
@jesec
API: torrents: use relative paths when creating archive for download
d1fef51
@jesec
API: torrents: remove confusing baseDirectory, baseFilename and baseP…
448075a 
…ath props
@jesec
server: tests: torrents: initial test case for /move
27e36d3
@jesec
server: qBittorrent: retrieve dateCreated and isPrivate properties
6b72a36
@jesec
client: TorrentList: properly handle added and removed properties
9bd18ae
@jesec
i18n: new placeholders (#72)
7633856
@jesec
dependencies: bump (major)
f15bd4b
@jesec
dependencies: switch to css-minimizer-webpack-plugin
a2fdc67
@jesec
dependencies: bump Webpack to 5
963c146
@jesec
TorrentMediainfo: allow horizontal scrolling
79d78b1
@jesec
dependencies: bump @types/d3 to 6.0.0
6a00264
jesec and others added 28 commits December 11, 2020 13:30
@jesec
Dockerfile: flatten Docker image layers
a971a3c
@jesec
Dockerfile.rtorrent: allow to specify Flood and rTorrent versions
95add1b
@jesec
Dockerfile: rollback aggressive cleanups
4c651ee 
The space savings are less significant than expected, and
the detachment from official image layers actually makes
incremental updates longer.

Plus, arguably the image is much more extensible with
package managers.
@jesec
CI: properly set version for rolling Docker image release
4f46c0e
@jesec
CI: add a step for jesec/rtorrent-flood rolling image
756b2e2
@jesec
dependencies: bump (minor)
afa0138
@jesec
dependencies: bump feedsub to 0.7.5
c97e50f
@jesec
client: refresh PWA assets and manifest
df86c67
@jesec
client: initial service worker support
3c015c6
@jesec
client: catch service worker registration errors
96347e4
@jesec
client: target more browsers with browserslist
67bf855
@jesec
TorrentActions: don't send empty start/stop requests
71ce340
@jesec
server: qBittorrent: avoid accessing undefined cookie object
94a77cc
@jesec
dependencies: bump feedsub to 0.7.6
cea33d5
@jesec
i18n: initial separation of locales and languages
3416308 
Bug: #123
@jesec
CI: disable Docker caching
d9d9dc2
@jesec
CI: lock Docker actions to last working versions
0d785f9
@jesec
Revert "CI: disable Docker caching"
cc469bd 
This reverts commit d9d9dc2.
@jesec
Revert "client: initial service worker support"
ac1ffdb 
This reverts commit 3c015c6.

Service worker does not work well with HTTP basic auth. Plus,
some caching policy problems need to be figured out first.
@jesec
client: properly serve public assets with webpack-dev-server
07a291a
@Carryozor @jesec
i18n: new translations for French (#124)
999463d
@jesec
Revert "CI: lock Docker actions to last working versions"
21c9b0e 
This reverts commit 0d785f9.
@jesec
CI: debug buildkitd
2806126
@jesec
client: implement "add-urls" frontend query action
d97a2c5 
Example:

http://localhost:3000/?action=add-urls&url=magnet:?xt=urn:btih:a88fda5954e89178c372716a6a78b8180ed4dad3
@jesec
client: allow to register to handle magnet links
1f02e9b
@jesec
server: torrents: disallow comma in tag
20fc3ac
@jesec
i18n: new placeholders (#126)
c537cbd
@Carryozor @jesec
i18n: new translations for French (#126)
1b375eb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jplot jplot jplot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.