Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22 Crash when timeout is not given #23

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Conversation

Demayl
Copy link
Contributor

@Demayl Demayl commented Jan 3, 2025

Check if timeout is True, because 0 means no timeout at all.
Add default timeout in the run-command example
Minor fix for #20 as scp is deprecated in general and maybe this function should be removed

@Demayl
Copy link
Contributor Author

Demayl commented Jan 9, 2025

@lizmat i can take over this module, as i have more optimizations and im working actively with this module

@lizmat
Copy link
Contributor

lizmat commented Jan 9, 2025

I can take over this module

That would be excellent!

If you would give me maintainer access to the organization you want to have it in, I can transfer the repo with all of its assets, such as open issues and pull requests.

After the transfer you can remove my access rights again :-)

@lizmat
Copy link
Contributor

lizmat commented Jan 9, 2025

Looks like the transfer is completed!

Please note that the repo has been set up for use with App::Mi6, so documentation is written as pod, and a mi6 release will release it to the ecosystem (once you've updated the "auth" in the META6.json).

Thanks again for taking this on!

@Demayl Demayl merged commit 0ddc2c8 into FluxArk:main Jan 11, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants