Fix ArrayIndexOutOfBoundsException in formatSize() on huge sizes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would crash on sizes greater than ~1.2e15 (1024 TB). By adding two more units, it will work on all possible Long values. Also make Int.formatSize() a simple wrapper for Long.formatSize() to avoid code repetition. And add attribution, because the code appears to have been copied from https://stackoverflow.com/posts/5599842/revisions#rev-body-85411f2d-9228-4768-9a7f-04c6d392a385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would crash on sizes greater than ~1.2e15 (1024 TB). By adding two more units, it will work on all possible Long values.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
Not tracked
Acknowledgement