-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not showing synced contact storage after upgrading to LOS21 (Android 14) #83
Comments
It's related to FossifyOrg/Phone#28. |
You are right. I found this issue and posted my "me too". |
I think is the same problem: stephanritscher/Simple-Contacts#20 After test: Simple contacts have this issue too. |
Quite possible as it seems to be a fork of the same code base. |
Yes. But it's possible to narrow down the part of the code. I think its an API issue. Whatsapp is showed in the filter and is also updated to targetSdk 34. Nine and Outlook are not showed and be at targetSdk 33. I use Android 14 (GrapheneOS) and the old version works without problem (targetSdk 33 of the contact app). |
I have the same problem with CARDDAV contacts. |
I think I have an issue related to this too. My contacts stored in Tuta are not syncing to Fossify Contacts, but they do sync to Google Contacts. In my filter list I have tickboxes to display contacts from the following apps:
Contacts from Tuta (Tutanota/Tuta Mail - recently rebranded) should also be shown as an option in this list but aren't. Device: Oppo A54 5G |
|
I haven't investigated this but here are the definitions: https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/services/core/java/com/android/server/content/SyncStorageEngine.java;l=260-289 |
For me the problem was contact not working without Google Services Framework installed. |
I'd like to add that allowing access to groups / individual contacts using the Contact Scopes feature (on GrapheneOS, maybe not available on LineageOS) lets the app show these groups / contacts. But the general Contacts permission does not work, and I also do not have Google Services Framework installed. |
@schklom You're right I just tested on GrapheneOS and that works. |
@Vysp3r A hacky inconvenient workaround is to create a group "All", put every contact in it, and allow that group. You would need to remember to add that group to each new contact in the future though, so far from ideal. |
OK, I give it a try. Installing Google Services Framework, nothing changed. Installing Google Play Services - the other accounts materialized magically in the app. So Google changed somewhat in the API? But Whatsapp is listed in the filters. GPS is not a option for me. And the work around from schklom is not a option too - anything delete the tags at the contacts randomly. I have no idea what ist happen. |
For now, I use the contact app of LineageOS as a temporary solution. I can provide debug log or other information, provided someone explain me how to get it. |
I use an older version of Stephans fork (https://github.com/stephanritscher/Simple-Contacts/releases/tag/6.22.4.2). A contact app with structured addresses is very rare... |
I also have this problem and I have attempted to debug it. I wish I had better news, as in isolating the root cause, but Android development has become wildly complicated (at least since I last looked at it). Here's what I (think I) know so far. I installed and run the debug with a breakpoint just before the line @cpontvieux-systra mentioned. From there I used Android Studio's "evaluation expression" to see what getIsSyncable returns and if I did it correctly, it is returning zero. So I don't think the suggested change would matter for us. In addition, I also loaded DavX5. When I look at every location in the code that sets setIsSyncable, it only sets it to either zero or one. These two things lead me to believe that perhaps the code should not be checking for syncable. I also loaded the code for the LineageOS contacts program from https://github.com/LineageOS/android_packages_apps_Contacts To be clear on this issue, I want to list my situation. It seems there may be more than one problem being described here. I am running LineageOS 21 on a Google Pixel 8. I did not install any Google services. I am using DavX5 to provide access to my Nextcloud server. Lineage's provided Contacts program can see my contacts, but Fossify can't. If anyone has any suggestions, perhaps how to get that LineageOS contacts program built so I can debug it and see why it works while Fossify doesn't, please share. |
At the Moment i have switched to an older Version of simple contacts 6.22.4 - everything after that does also not work with the same result as fossify contacts. |
@ksapp-dell Halleluja! |
Fixed in FossifyOrg/Commons#55. |
I was still testing out the proposed fix and in my case, contacts still disappear when I disable google play services. I have attached two APKs for testing: |
I confirm, I installed the two apks and the problem persist. And yes I don’t have any Google play service on my device (neither active, nor installed) |
It would be great, if you could create a new release once this is fixed... |
Will do! |
This seems to me the most promising hint for this issue (i.e. some sort of regression in 6.22.5), but I'm too unfamiliar with this app looking at the commits what it could be. |
The app was targeting Android 13 before version 6.22.5, that's why it works. |
Hello, I also have the same or similar problems with dialer and contacts apps (both fossify and simplemobiletools versions). Reverting to earlier version of simplemobiletools (v6.22.3 contacts & v5.17.8 dialer) the contacts works flawlessly on Pixel8 - Android 14 - GrapheneOS with no google services installed. |
It should be fixed in the next update. |
I am glad to report that with 1.1.0 update this issue is fixed on my device. (Lineage OS 21, Oneplus 9 Pro) |
Same here, issue is fixed (GrapheneOS, A15 without GPS) |
It fixed it. I can now switch back to Fossify contacts/phone/sms apps. |
Could you also update the Phone app as well? |
Fixed for me aswell, thx! Phone/Dialer app still needs an update though. Anyways, great stuff. Donation inbound. |
Done: https://github.com/FossifyOrg/Phone/releases/tag/1.3.0 Thanks for confirming the fix! |
@naveensingh I confirm that this works on latest GrapheneOS (Android 15) |
This is great. Now, how do we get this update pushed to F-Droid? |
@arkdae it's already there. |
Terribly sorry. I didn't realize my local copy of the F-Droid repo was not up to date. It's all working great now. Thanks for your support. |
Checklist
Affected app version
1.0.1.
Affected Android/Custom ROM version
LineageOS 21 (Android 14)
Affected device model
Moto G7 Plus (lake)
How did you install the app?
F-Droid / IzzyOnDroid
Steps to reproduce the bug
Open the contacts app.
Go to contacts or favorites pane.
Click on filter button to choose contact storage to be shown.
Expected behavior
Filtering option in contacts app (and phone app as well) should show synced contact storage.
Actual behavior
Filtering option in contacts app (and phone app as well) only showing phone storage and phone storage (not visible by other apps).
Screenshots/Screen recordings
No response
Additional information
On LOS20 (Android 13) everything was fine.
After upgrading to LOS21 (Android 14) the synced contacts are not shown in contacts app (and phone app as well).
Syncing of contacts is done with davx5 (https://github.com/bitfireAT/davx5-ose).
The text was updated successfully, but these errors were encountered: