Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing synced contact storage after upgrading to LOS21 (Android 14) #83

Closed
7 tasks done
nucular8 opened this issue Feb 18, 2024 · 38 comments
Closed
7 tasks done
Labels
bug Something is not working device/software specific Issues that only happen on some devices or with some specific hardware/software

Comments

@nucular8
Copy link

nucular8 commented Feb 18, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.1.

Affected Android/Custom ROM version

LineageOS 21 (Android 14)

Affected device model

Moto G7 Plus (lake)

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

Open the contacts app.
Go to contacts or favorites pane.
Click on filter button to choose contact storage to be shown.

Expected behavior

Filtering option in contacts app (and phone app as well) should show synced contact storage.

Actual behavior

Filtering option in contacts app (and phone app as well) only showing phone storage and phone storage (not visible by other apps).

Screenshots/Screen recordings

No response

Additional information

On LOS20 (Android 13) everything was fine.
After upgrading to LOS21 (Android 14) the synced contacts are not shown in contacts app (and phone app as well).
Syncing of contacts is done with davx5 (https://github.com/bitfireAT/davx5-ose).

@nucular8 nucular8 added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Feb 18, 2024
@Aga-C Aga-C added the device/software specific Issues that only happen on some devices or with some specific hardware/software label Feb 18, 2024
@nucular8 nucular8 changed the title Filter does not show synced contact storage after upgrading to LOS21 Not showing synced contact storage after upgrading to LOS21 (Android 14) Feb 18, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 18, 2024

It's related to FossifyOrg/Phone#28.

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 18, 2024
@nucular8
Copy link
Author

You are right. I found this issue and posted my "me too".
I guess it's the same piece of code that affects both apps.

@Mrothyr
Copy link

Mrothyr commented Feb 19, 2024

I think is the same problem:

stephanritscher/Simple-Contacts#20

After test: Simple contacts have this issue too.

@nucular8
Copy link
Author

Quite possible as it seems to be a fork of the same code base.

@Mrothyr
Copy link

Mrothyr commented Feb 19, 2024

Yes. But it's possible to narrow down the part of the code.

I think its an API issue. Whatsapp is showed in the filter and is also updated to targetSdk 34. Nine and Outlook are not showed and be at targetSdk 33. I use Android 14 (GrapheneOS) and the old version works without problem (targetSdk 33 of the contact app).

@czarnyckm
Copy link

czarnyckm commented Feb 23, 2024

I have the same problem with CARDDAV contacts.
Works fine with 'koler' or 'contacts you'
as well as 'Simple Contacts Pro SE' f-droid version 6.22.4.2 Pro (the Github version is broken since January update)

@jurdabur
Copy link

I think I have an issue related to this too. My contacts stored in Tuta are not syncing to Fossify Contacts, but they do sync to Google Contacts.

In my filter list I have tickboxes to display contacts from the following apps:

  • WhatsApp
  • Google Accounts
  • Signal
  • Messenger (Facebook/Meta)
  • Phone storage
  • Phone storage (not visible by other apps)

Contacts from Tuta (Tutanota/Tuta Mail - recently rebranded) should also be shown as an option in this list but aren't.

Device: Oppo A54 5G
Android OS: ColorOS 13.0 (Android 13)
Version: Fossify Contacts 1.0.1 (F-Droid)

@naveensingh
Copy link
Member

@Vysp3r
Copy link

Vysp3r commented May 8, 2024

For me the problem was contact not working without Google Services Framework installed.
I don't know why it would depend on that though.

@schklom
Copy link

schklom commented May 8, 2024

I'd like to add that allowing access to groups / individual contacts using the Contact Scopes feature (on GrapheneOS, maybe not available on LineageOS) lets the app show these groups / contacts.

But the general Contacts permission does not work, and I also do not have Google Services Framework installed.

@Vysp3r
Copy link

Vysp3r commented May 8, 2024

@schklom You're right I just tested on GrapheneOS and that works.
It's not great though, because I would have to go in there and add each contact manually each time I add some.
It makes me wonder why they would show up properly with Google Services Framework installed.

@schklom
Copy link

schklom commented May 8, 2024

@Vysp3r A hacky inconvenient workaround is to create a group "All", put every contact in it, and allow that group. You would need to remember to add that group to each new contact in the future though, so far from ideal.

@Mrothyr
Copy link

Mrothyr commented May 15, 2024

OK, I give it a try. Installing Google Services Framework, nothing changed. Installing Google Play Services - the other accounts materialized magically in the app.

So Google changed somewhat in the API? But Whatsapp is listed in the filters.

GPS is not a option for me. And the work around from schklom is not a option too - anything delete the tags at the contacts randomly. I have no idea what ist happen.

@cpontvieux-systra
Copy link

For now, I use the contact app of LineageOS as a temporary solution.
But yes, Google services are not an option for me either.

I can provide debug log or other information, provided someone explain me how to get it.
I’m a developper, but not a Android developper…

@Mrothyr
Copy link

Mrothyr commented May 18, 2024

I use an older version of Stephans fork (https://github.com/stephanritscher/Simple-Contacts/releases/tag/6.22.4.2). A contact app with structured addresses is very rare...

@arkdae
Copy link

arkdae commented May 25, 2024

I also have this problem and I have attempted to debug it. I wish I had better news, as in isolating the root cause, but Android development has become wildly complicated (at least since I last looked at it). Here's what I (think I) know so far.

I installed and run the debug with a breakpoint just before the line @cpontvieux-systra mentioned. From there I used Android Studio's "evaluation expression" to see what getIsSyncable returns and if I did it correctly, it is returning zero. So I don't think the suggested change would matter for us.

In addition, I also loaded DavX5. When I look at every location in the code that sets setIsSyncable, it only sets it to either zero or one. These two things lead me to believe that perhaps the code should not be checking for syncable.

I also loaded the code for the LineageOS contacts program from https://github.com/LineageOS/android_packages_apps_Contacts
Unfortunately, unlike either Fossfy Contacts or DavX5, when I pull the Git repo into Android Studio, it is not in whatever form it needs to be to automagically be compilable and debuggable on my device. However, I did look at the code, and it seems that they only care about syncability specifically for Google contacts. Since I am not using Google anything, I suspect this code is not used for my contacts list.

To be clear on this issue, I want to list my situation. It seems there may be more than one problem being described here. I am running LineageOS 21 on a Google Pixel 8. I did not install any Google services. I am using DavX5 to provide access to my Nextcloud server. Lineage's provided Contacts program can see my contacts, but Fossify can't.

If anyone has any suggestions, perhaps how to get that LineageOS contacts program built so I can debug it and see why it works while Fossify doesn't, please share.

@ksapp-dell
Copy link

ksapp-dell commented Aug 25, 2024

At the Moment i have switched to an older Version of simple contacts 6.22.4 - everything after that does also not work with the same result as fossify contacts.

@paskalito
Copy link

@ksapp-dell Halleluja!
thanks for that work around i can finally manage my contacts again!

@Aga-C
Copy link
Member

Aga-C commented Sep 3, 2024

Fixed in FossifyOrg/Commons#55.

@Aga-C Aga-C closed this as completed Sep 3, 2024
@naveensingh
Copy link
Member

I was still testing out the proposed fix and in my case, contacts still disappear when I disable google play services. I have attached two APKs for testing:

@naveensingh naveensingh reopened this Sep 3, 2024
@cpontvieux-systra
Copy link

I confirm, I installed the two apks and the problem persist. And yes I don’t have any Google play service on my device (neither active, nor installed)

@jzbor
Copy link

jzbor commented Sep 6, 2024

It would be great, if you could create a new release once this is fixed...

@naveensingh
Copy link
Member

Will do!

@nofishonfriday
Copy link

At the Moment i have switched to an older Version of simple contacts 6.22.4 - everything after that does also not work with the same result as fossify contacts.

(#83 (comment))

This seems to me the most promising hint for this issue (i.e. some sort of regression in 6.22.5), but I'm too unfamiliar with this app looking at the commits what it could be.

@naveensingh
Copy link
Member

The app was targeting Android 13 before version 6.22.5, that's why it works.

@PalmTreeVI
Copy link

PalmTreeVI commented Oct 16, 2024

Hello, I also have the same or similar problems with dialer and contacts apps (both fossify and simplemobiletools versions). Reverting to earlier version of simplemobiletools (v6.22.3 contacts & v5.17.8 dialer) the contacts works flawlessly on Pixel8 - Android 14 - GrapheneOS with no google services installed.

@naveensingh
Copy link
Member

naveensingh commented Oct 27, 2024

It should be fixed in the next update.

https://github.com/FossifyOrg/Contacts/releases/tag/1.1.0

@eagerto-learn
Copy link

eagerto-learn commented Oct 28, 2024

I am glad to report that with 1.1.0 update this issue is fixed on my device. (Lineage OS 21, Oneplus 9 Pro)

@Mrothyr
Copy link

Mrothyr commented Oct 28, 2024

Same here, issue is fixed (GrapheneOS, A15 without GPS)

@cpontvieux-systra
Copy link

It fixed it. I can now switch back to Fossify contacts/phone/sms apps.
Thx

@schklom
Copy link

schklom commented Oct 28, 2024

Could you also update the Phone app as well?

@OminousLama
Copy link

Fixed for me aswell, thx! Phone/Dialer app still needs an update though.

Anyways, great stuff. Donation inbound.

@naveensingh
Copy link
Member

naveensingh commented Oct 30, 2024

Could you also update the Phone app as well?

Done: https://github.com/FossifyOrg/Phone/releases/tag/1.3.0

Thanks for confirming the fix!

@Vysp3r
Copy link

Vysp3r commented Oct 30, 2024

@naveensingh I confirm that this works on latest GrapheneOS (Android 15)

@arkdae
Copy link

arkdae commented Nov 15, 2024

This is great. Now, how do we get this update pushed to F-Droid?

@naveensingh
Copy link
Member

@arkdae it's already there.

@arkdae
Copy link

arkdae commented Nov 15, 2024

Terribly sorry. I didn't realize my local copy of the F-Droid repo was not up to date. It's all working great now. Thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working device/software specific Issues that only happen on some devices or with some specific hardware/software
Projects
None yet
Development

No branches or pull requests