Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multi version tests #3047

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enable multi version tests #3047

wants to merge 6 commits into from
+21 −109

Conversation

ohadzeliger
Copy link
Contributor

Enable yaml tests that were disabled before, now that the gaps have been filled.

@ohadzeliger ohadzeliger self-assigned this Jan 15, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: 0937485
  • Duration 0:51:49
  • Result: ❌ FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: 0618248
  • Duration 0:53:00
  • Result: ❌ FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: d2e0df6
  • Duration 0:54:34
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@ohadzeliger ohadzeliger marked this pull request as ready for review January 16, 2025 13:40
ScottDugas
ScottDugas requested changes Jan 16, 2025
View reviewed changes
...main/java/com/apple/foundationdb/relational/yamltests/server/RunExternalServerExtension.java
@@ -87,7 +86,6 @@ public String getVersion() {

@Override
public void beforeAll(ExtensionContext context) throws Exception {
Assumptions.abort(); // Will be able to re-enable when we have a published external server to use here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the issues with explain changing between versions, I'm not sure that we want to enable this as part of prb yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean in general, or just for the tests that contain explain assertions?

@ohadzeliger ohadzeliger force-pushed the enable-multi-version-tests branch from 0ce1b86 to 897bcbc Compare January 23, 2025 18:03
@FoundationDB FoundationDB deleted a comment from foundationdb-ci Jan 23, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: 0ce1b86
  • Duration 0:54:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: 897bcbc
  • Duration 0:55:15
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottDugas ScottDugas Awaiting requested review from ScottDugas

Requested changes must be addressed to merge this pull request.

Assignees

@ohadzeliger ohadzeliger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohadzeliger @foundationdb-ci @ScottDugas