Fixes for Gradle tasks for Antlr #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-record-layer-pr on Linux CentOS 7
|
alecgrieser
previously approved these changes
Jan 31, 2025
| @@ -21,6 +21,7 @@ | |||
| apply plugin: 'antlr' | |||
|
|
|||
| generateGrammarSource { | |||
| outputDirectory = layout.buildDirectory.dir('generated-src/antlr/main/com/apple/foundationdb/relational/generated').get().asFile | |||
There was a problem hiding this comment.
We'll have to think at some point how to make this more generic so that it accepts different package names, though for now, this should be fine. Something we will have to notice if we ever change the hardcoded package below
There was a problem hiding this comment.
Yeah, let's cross that bridge when we reach it then.
* add post task that copies .token files to fdb-relational-core/src/main/antlr this makes the IDE able to parse the grammar files correctly.
hatyo
force-pushed
the
gradle-fixes-for-antlr
branch
from
ebac74a to
d894093
Compare
alecgrieser
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two fixes:
generateGrammarSourcetask which copies all*.tokenfiles next to the grammar and lexer files insrc/main/antlr. These files are added to.gitignoreto avoid checking them in by mistake.These effectively enable the IDE to correctly parse and present the grammar files as well as the generated files, before it was showing hundreds of errors due to file location mismatch and the inability to link the grammar file with the respective tokens array.