fix cockroachdb tests

FrancoLiberali · Jan 2, 2024 · 9502306 · 9502306
1 parent 965d6bd
commit 9502306
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/condition/field_value.go b/condition/field_value.go
@@ -62,29 +62,21 @@ func (value NumericFieldValue[TModel, TAttribute]) getType() numeric {
 }
 
 // Plus sums other to value
-//
-// Warning: in PostgreSQL the value received by parameter could be casted to integer
 func (value *NumericFieldValue[TModel, TAttribute]) Plus(other float64) *NumericFieldValue[TModel, TAttribute] {
 	return value.addOperation(other, "+")
 }
 
 // Minus subtracts other from the value
-//
-// Warning: in PostgreSQL the value received by parameter could be casted to integer
 func (value *NumericFieldValue[TModel, TAttribute]) Minus(other float64) *NumericFieldValue[TModel, TAttribute] {
 	return value.addOperation(other, "-")
 }
 
 // Times multiplies value by other
-//
-// Warning: in PostgreSQL the value received by parameter could be casted to integer
 func (value *NumericFieldValue[TModel, TAttribute]) Times(other float64) *NumericFieldValue[TModel, TAttribute] {
 	return value.addOperation(other, "*")
 }
 
 // Divided divides value by other
-//
-// Warning: in PostgreSQL the value received by parameter could be casted to integer
 func (value *NumericFieldValue[TModel, TAttribute]) Divided(other float64) *NumericFieldValue[TModel, TAttribute] {
 	return value.addOperation(other, "/")
 }

diff --git a/test/update_test.go b/test/update_test.go
@@ -702,18 +702,26 @@ func (ts *UpdateIntTestSuite) TestUpdateDynamicWithFunction() {
 		ts.db,
 		conditions.Product.Bool.Is().False(),
 	).Set(
-		conditions.Product.Int.Set().Dynamic(conditions.Product.Float.Value().Plus(1)),
+		conditions.Product.Int.Set().Dynamic(conditions.Product.Float.Value().Plus(1.1)),
 	)
-	ts.Require().NoError(err)
-	ts.Equal(int64(1), updated)
 
-	productReturned, err := cql.Query[models.Product](
-		ts.db,
-		conditions.Product.Int.Is().Eq(2),
-	).FindOne()
-	ts.Require().NoError(err)
+	if getDBDialector() == cqlSQL.Postgres && err != nil {
+		// cockroachdb
+		ts.ErrorContains(err, "unsupported binary operator: <decimal> + <anyelement> (desired <int>) (SQLSTATE 22023); method: Set")
+	} else {
+		ts.Require().NoError(err)
+		ts.Equal(int64(1), updated)
+
+		productReturned, err := cql.Query[models.Product](
+			ts.db,
+			conditions.Product.Int.Is().Eq(2),
+		).FindOne()
+
+		ts.Require().NoError(err)
+
+		ts.Equal(product1.ID, productReturned.ID)
+		ts.Equal(2, productReturned.Int)
+		ts.NotEqual(product1.UpdatedAt.UnixMicro(), productReturned.UpdatedAt.UnixMicro())
+	}
 
-	ts.Equal(product1.ID, productReturned.ID)
-	ts.Equal(2, productReturned.Int)
-	ts.NotEqual(product1.UpdatedAt.UnixMicro(), productReturned.UpdatedAt.UnixMicro())
 }