Update C# langversion to 13

.github/workflows/build.yml

@@ -13,46 +13,48 @@ jobs:
   build:
     name: build
     runs-on: windows-latest
+    permissions:
+      contents: write
+      pull-requests: write
+      checks: write
     steps:
         #clone, setup dotnet, restore packages
       - name: Checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
+      - name: get version
+        shell: pwsh
+        run: |
+            $version = select-xml -path "Directory.Build.props" -xpath "//PropertyGroup//Version" | Select-Object  -ExpandProperty Node | Select-Object -ExpandProperty '#text'
+            echo "VERSION=$version" >> $env:GITHUB_ENV
+
       - name: setup dotnet
         uses: actions/setup-dotnet@v3
 
       - name: dotnet restore
         run: dotnet restore
 
-      - name: setup sonarqube
-        if: ${{ !github.event.pull_request.head.repo.fork }}
-        uses: ./.github/actions/setup-sonar
+      - name: Build solution
+        run: dotnet build -c release
 
-        #build with sonar analysis enabled
-      - name: Build and analyze
+      - name: Run tests with code coverage
+        run: dotnet test /p:CollectCoverage=true /p:CoverletOutput=../../.qodana/code-coverage/ /p:CoverletOutputFormat=lcov
+
+      - name: Qodana Scan
         if: ${{ !github.event.pull_request.head.repo.fork }}
+        continue-on-error: true
+        uses: JetBrains/[email protected]
+        with:
+          args: --baseline,qodana.sarif.json
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        shell: powershell
-        run: |
-          .\.sonar\scanner\dotnet-sonarscanner begin /k:"FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="${{ secrets.SONAR_HOST_URL }}" /d:sonar.cs.opencover.reportsPaths=tests/**/*.xml
-          dotnet build src/soulsplitter/soulsplitter.csproj -c release /p:Platform=x64
-          dotnet test -p:CollectCoverage=true -p:CoverletOutputFormat=opencover
-          .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"
-
-        #Forked repo's don't have access to the repository secrets and are unable to run sonarqube analysis
-      - name: Build only
-        if: ${{ github.event.pull_request.head.repo.fork }}
-        shell: powershell
-        run: |
-            dotnet build src/soulsplitter/soulsplitter.csproj -c release /p:Platform=x64
-            dotnet test
-
-      - name: Build CliTimer
-        shell: powershell
-        run: dotnet build src\CliTimer\CliTimer.csproj -c release /p:Platform=x64
+          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
+
+      - name: upload to github code scanning
+        uses: github/codeql-action/upload-sarif@v2
+        with:
+          sarif_file: ${{ runner.temp }}/qodana/results/qodana.sarif.json
 
         #Collect all the artifacts and publish them
       - name: collect artifacts
@@ -98,5 +100,5 @@ jobs:
       - name: Publish SoulSplitter
         uses: actions/upload-artifact@v4
         with:
-          name: SoulSplitter
+          name: ${{ env.VERSION }}
           path: artifact

README.md

@@ -17,19 +17,6 @@
 </p>
 
 <p align="center">
-    <a href="https://sonarqube.wastedcloud.nl/dashboard?id=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa">
-        <img src="https://sonarqube.wastedcloud.nl/api/project_badges/measure?project=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa&metric=alert_status&token=dcf5066558434982e851acb72b72235195d99b6e&branch=main"/> 
-    </a>
-    <a href="https://sonarqube.wastedcloud.nl/dashboard?id=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa">
-        <img src="https://sonarqube.wastedcloud.nl/api/project_badges/measure?project=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa&metric=ncloc&token=dcf5066558434982e851acb72b72235195d99b6e&branch=main"/>
-    </a>
-    <a href="https://sonarqube.wastedcloud.nl/dashboard?id=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa">
-        <img src="https://sonarqube.wastedcloud.nl/api/project_badges/measure?project=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa&metric=coverage&token=dcf5066558434982e851acb72b72235195d99b6e&branch=main"/>
-    </a>
-    <a href="https://sonarqube.wastedcloud.nl/dashboard?id=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa">
-        <img src="https://sonarqube.wastedcloud.nl/api/project_badges/measure?project=FrankvdStam_SoulSplitter_AYT9tJW7QlZ0fhD27xsa&metric=sqale_rating&token=dcf5066558434982e851acb72b72235195d99b6e&branch=main"/>
-    </a>
-    <br/>
     <a href="https://github.com/FrankvdStam/SoulSplitter/actions">
         <img src="https://img.shields.io/github/actions/workflow/status/FrankvdStam/SoulSplitter/build.yml?branch=main"/>
     </a>

SoulSplitter.sln

@@ -65,7 +65,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{
 		.github\workflows\build.yml = .github\workflows\build.yml
 		.github\workflows\debug.yml = .github\workflows\debug.yml
 		.github\workflows\issues.yml = .github\workflows\issues.yml
-		.github\workflows\qodana.yml = .github\workflows\qodana.yml
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "setup-sonar", "setup-sonar", "{2F6D0351-99A1-4E2A-98B8-7FE636A53F89}"