Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SA violation fixes and simplification for idle task length restrictions #1227

Merged
merged 11 commits into from
Jan 28, 2025

Conversation

kstribrnAmzn
Copy link
Member

@kstribrnAmzn kstribrnAmzn commented Jan 21, 2025

Description

This change:

  • Removes the dependency on strings.h for the prvCreateIdleTask function
  • Resolves several static analysis violations reported by tools like Parasoft

Test Steps

This change is being introduced for our upcoming safety certification release. This has been tested by our safety UTs.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

Builds off of #1203

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ictions

This change:
* Removes the dependency on strings.h for the prvCreateIdleTask function
* Resolves several static analysis violations reported by tools like Parasoft

Builds off of - FreeRTOS#1203
@kstribrnAmzn kstribrnAmzn requested a review from a team as a code owner January 21, 2025 16:32
tasks.c Outdated Show resolved Hide resolved
@kstribrnAmzn
Copy link
Member Author

The GNU ARM toolchain demo is failing due to...

./../../../../Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h:139:10: fatal error: trcRecorder.h: No such file or directory
  139 | #include "trcRecorder.h"

Given I did not modify the FreeRTOSConfig.h file, I think this PR is in the clear.

MISRA.md Outdated Show resolved Hide resolved
MISRA.md Outdated Show resolved Hide resolved
tasks.c Outdated Show resolved Hide resolved
tasks.c Outdated Show resolved Hide resolved
tasks.c Outdated Show resolved Hide resolved
tasks.c Outdated Show resolved Hide resolved
Comment updates

Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.65%. Comparing base (31dd1e3) to head (f9c020e).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
+ Coverage   91.64%   91.65%   +0.01%     
==========================================
  Files           6        6              
  Lines        3254     3259       +5     
  Branches      903      901       -2     
==========================================
+ Hits         2982     2987       +5     
  Misses        132      132              
  Partials      140      140              
Flag Coverage Δ
unittests 91.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aggarg aggarg merged commit f94bc89 into FreeRTOS:main Jan 28, 2025
17 checks passed
@kstribrnAmzn kstribrnAmzn deleted the idleTaskSAFixes branch January 28, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants