imx93: add fixes to enable multilib out-of-the-box #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarcoscosta
force-pushed
the
fix-overrides-for-multilib
branch
from
98b165a to
47bbd3f
Compare
|
Update: the override I previously used was restricted to I added a new override, namely |
|
Thank you for your work on this pull request. However, I would prefer to explicitly keep the overrides. Would you mind reworking it to use |
|
Hello, @otavio I'm not sure if I understood you correctly. Did you mean having each variable defined twice, using the two overrides? Like this: Best regards, |
|
@jmarcoscosta exactly! 👍🏻 |
Using 'aarch64', as if the KERNEL_IMAGETYPE was conditioned to the userspace's architecture, will cause the wrong image type to be built in a multilib context (e.g., for a 32-bit userspace). This happens because 'aarch64' will not be listed in OVERRIDES, and the error below will come up during do_image_wic task: output: install: cannot stat '...build/tmp-glibc/deploy/images/microej-imx93/zImage': No such file or directory Replace 'aarch64' by mx*-generic-bsp, for both imx8 and imx9, as these two are aarch64 platforms. Signed-off-by: Joao Marcos Costa <[email protected]>
Using 'aarch64', as if the OPTEE_BOOT_IMAGE was conditioned to the
userspace's architecture, will include uTee-${OPTEE_BIN_EXT} in a multilib
context (e.g., for a 32-bit userspace). This happens because 'aarch64' will not
be listed in OVERRIDES, and the error below will come up during do_image_wic
task:
output: install:
cannot stat '...build/tmp-glibc/deploy/images/microej-imx93/uTee-':
No such file or directory
Replace 'aarch64' by mx*-generic-bsp, for both imx8 and imx9, as these
two are aarch64 platforms.
Signed-off-by: Joao Marcos Costa <[email protected]>
Using 'aarch64', as if the WKS_FILE_DEPENDS was conditioned to the userspace's architecture, will not include imx-boot in a multilib context (e.g., for a 32-bit userspace). This happens because 'aarch64' will not be listed in OVERRIDES, and the error below will come up during do_image_wic task: wic.filemap.Error: cannot open image file '.../build/tmp-glibc/deploy/images/microej-imx93/imx-boot': [Errno 2] No such file or directory Replace 'aarch64' by mx*-generic-bsp, for both imx8 and imx9, as these two are aarch64 platforms. Signed-off-by: Joao Marcos Costa <[email protected]>
The sstate manifest for populate_sysroot was not being named
properly for firmware-sentinel and imx-boot-firmware-files, raising the
following error:
The sstate manifest for task 'firmware-sentinel:populate_sysroot'
(multilib variant '') could not be found.
The pkgarchs considered were: microej_imx93, armv7ahf-neon-vfpv4-mx93,
armv7ahf-neon-mx93, (and so on...)
But none of these manifests exists:
...build/tmp-glibc/sstate-control/manifest-microej_imx93-imx-boot-firmware-files.populate_sysroot
...build/tmp-glibc/sstate-control/manifest-armv7ahf-neon-vfpv4-mx93-imx-boot-firmware-files.populate_sysroot
... and so on.
All the other packages were suffixed with TUNE_PKGARCH only, so I couldn't
see the reason why only some specific packages from meta-freescale were using
that.
Remove MACHINE_SOCARCH_SUFFIX so as the sstate manifest is compatible
with what's expected in populate_sysroot.
Signed-off-by: Joao Marcos Costa <[email protected]>
jmarcoscosta
force-pushed
the
fix-overrides-for-multilib
branch
from
47bbd3f to
6579ce9
Compare
|
PR updated. |
thochstein
reviewed
Dec 31, 2023
| @@ -74,7 +74,7 @@ python __anonymous () { | |||
| d.appendVar("PACKAGE_EXTRA_ARCHS", " %s" % d.getVar("THUMB_EXTRA_SOCARCH")) | |||
| } | |||
|
|
|||
| MACHINE_SOCARCH = "${TUNE_PKGARCH}${MACHINE_SOCARCH_SUFFIX}" | |||
| MACHINE_SOCARCH = "${TUNE_PKGARCH}" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have been trying to build a 32-bit userspace + 64-bit kernel system through multilib. However, this feature doesn't seem to work out-of-the-box, and some fixes were needed so I could have a flawless build. The target I used in this context was
lib32-core-image-minimal.The main goal of this PR is to fix erroneous overrides that end up using the userspace architecture. Those overrides are not taken into consideration if the userspace architecture is something other than
aarch64.Best regards,
João