imx-base: follow renamed fw package name #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9a52220 ("firmware-imx: Use vpu-amphion and vpu-wave suffix.") renamed the vpu firmware package name from firmware-vpu-imx8 to firmware-imx-vpu-amphion. Follow that in the setting of MACHINE_FIRMWARE setting. Signed-off-by: Max Krummenacher <[email protected]>
|
Successfully created backport PR #1827 for |
|
@MaxKrummenacher , sorry I missed this. Thanks for the notice. We are fine with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9a52220 ("firmware-imx: Use vpu-amphion and vpu-wave suffix.") renamed the vpu firmware package name from firmware-vpu-imx8 to firmware-imx-vpu-amphion.
Follow that in the setting of MACHINE_FIRMWARE setting.
@thochstein :
meta-imx is still using the package names from before commit 9a52220.
meta-imx-bsp/recipes-bsp/firmware-imx/firmware-imx_8.23.bb creates the old package names, thus the imx8 vpu fw will not be installed assuming the meta-imx recipe wins.
meta-imx-bsp/conf/machine/include/imx-base-extend.inc: installs " firmware-imx-vpu-imx95", thus the imx95 vpu fw will not be installed assuming the meta-freescale recipe wins.
Should we revert commit 9a52220 rather than merging what I propose in the recipe here?