-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Grafana Guide, fixes #33 #41
base: main
Are you sure you want to change the base?
Conversation
p.s. I think these are a lot of ss 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Is the dashboard code collapsed by default?
@SSmale I'm not sure I understand your comment. Could you tell me more about what you mean by 'Is the dashboard code collapsed by default?' |
@SSmale also thank you very much for the brief issue. I used most of the comments in the guide 🕺🏼 |
https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab see the first example, the block is closed so you're not greeted with a wall of text that you might not need. |
ah cool cool, this is great let me look how to do this in mintlify |
For completeness and to possibly save your sanity, I do not know if it is possible in this projects doc engine. |
commit ref 4d45a90 I tried it it doesn't seem to work in mintlify. @christianmat I was not able to link json with relative path imports so for this above image demo. I added the deteminsitic link where the file would be present in the future https://raw.githubusercontent.com/FrigadeHQ/trench/refs/heads/main/apps/docs/json/grafana-dashboard.json (the file would only be available after the merge in the main branch) let me know what do you think about this approach @SSmale Also I changed markdown steps to https://mintlify.com/docs/content/components/steps#steps |
The deep link looks like a good solution to me. Great work. Waiting for @SSmale to confirm it looks good and then we can merge. |
Yeah looks like a great solution! |
Fixes #33
Hi @SSmale and @christianmat,
I've made some changes to simplify the steps and omitted certain parts to keep the guide clean. Please review and let me know if you’d like any adjustments to the tone or the direction of the guide.
adding ss for you ref