Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro-when): Use new injectTypes utility when available #157

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Fryuni
Copy link
Owner

@Fryuni Fryuni commented Sep 4, 2024

@Fryuni Fryuni self-assigned this Sep 4, 2024
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inox-tools ✅ Ready (Inspect) Visit Preview Sep 4, 2024 1:28am

@Fryuni
Copy link
Owner Author

Fryuni commented Sep 4, 2024

!snapshot inject-types

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Snapshots have been released for the following packages:

  • @inox-tools/astro-when@pr--inject-types
Publish Log
🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the pr--inject-types tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @inox-tools/aik-mod
🦋  info npm info @inox-tools/aik-route-config
🦋  info npm info @inox-tools/astro-when
🦋  info npm info @inox-tools/content-utils
🦋  info npm info @inox-tools/custom-routing
🦋  info npm info @inox-tools/inline-mod
🦋  info npm info @inox-tools/modular-station
🦋  info npm info @inox-tools/request-nanostores
🦋  info npm info @inox-tools/request-state
🦋  info npm info @inox-tools/runtime-logger
🦋  info npm info @inox-tools/sitemap-ext
🦋  info npm info @inox-tools/star-warp
🦋  info npm info @inox-tools/utils
🦋  info npm info @inox-tools/velox-luna
🦋  warn @inox-tools/aik-mod is not being published because version 0.8.2 is already published on npm
🦋  warn @inox-tools/aik-route-config is not being published because version 0.7.2 is already published on npm
🦋  info @inox-tools/astro-when is being published because our local version (0.0.0-inject-types-20240904013805) has not been published on npm
🦋  warn @inox-tools/content-utils is not being published because version 0.7.0 is already published on npm
🦋  warn @inox-tools/custom-routing is not being published because version 0.4.0 is already published on npm
🦋  warn @inox-tools/inline-mod is not being published because version 1.5.0 is already published on npm
🦋  warn @inox-tools/modular-station is not being published because version 0.3.0 is already published on npm
🦋  warn @inox-tools/request-nanostores is not being published because version 0.1.1 is already published on npm
🦋  warn @inox-tools/request-state is not being published because version 0.1.1 is already published on npm
🦋  warn @inox-tools/runtime-logger is not being published because version 0.3.1 is already published on npm
🦋  warn @inox-tools/sitemap-ext is not being published because version 0.3.3 is already published on npm
🦋  warn @inox-tools/star-warp is not being published because version 0.1.1 is already published on npm
🦋  warn @inox-tools/utils is not being published because version 0.1.3 is already published on npm
🦋  warn @inox-tools/velox-luna is not being published because version 0.3.2 is already published on npm
🦋  info Publishing "@inox-tools/astro-when" at "0.0.0-inject-types-20240904013805"
🦋  success packages published successfully:
🦋  @inox-tools/[email protected]
🦋  Creating git tag...
🦋  New tag:  @inox-tools/[email protected]
Build Log

> [email protected] build /home/runner/work/inox-tools/inox-tools
> turbo run --filter '@inox-tools/*' build

turbo 2.0.14

• Packages in scope: @inox-tools/aik-mod, @inox-tools/aik-route-config, @inox-tools/astro-when, @inox-tools/content-utils, @inox-tools/custom-routing, @inox-tools/inline-mod, @inox-tools/modular-station, @inox-tools/request-nanostores, @inox-tools/request-state, @inox-tools/runtime-logger, @inox-tools/sitemap-ext, @inox-tools/star-warp, @inox-tools/utils, @inox-tools/velox-luna
• Running build in 14 packages
• Remote caching enabled
::group::@inox-tools/custom-routing:build
cache hit, suppressing logs 0a27de631a026a3e
::endgroup::
::group::@inox-tools/utils:build
cache hit, suppressing logs d4686406e72790d0
::endgroup::
::group::@inox-tools/velox-luna:build
cache hit, suppressing logs 63867cd2fbd5d89c
::endgroup::
::group::@inox-tools/inline-mod:build
cache hit, suppressing logs b8b953eb3b6ae59c
::endgroup::
::group::@inox-tools/aik-route-config:build
cache hit, suppressing logs 013abe36bbf2cbf0
::endgroup::
::group::@inox-tools/modular-station:build
cache hit, suppressing logs c0332ba8dab666fe
::endgroup::
::group::@inox-tools/request-state:build
cache hit, suppressing logs 1a819f4a10e1e609
::endgroup::
::group::@inox-tools/star-warp:build
cache hit, suppressing logs 344feda20dec6bc9
::endgroup::
::group::@inox-tools/aik-mod:build
cache hit, suppressing logs 64407bd9c43ca575
::endgroup::
::group::@inox-tools/sitemap-ext:build
cache hit, suppressing logs b859e1ee5c4e4c8c
::endgroup::
::group::@inox-tools/content-utils:build
cache hit, suppressing logs 36d2c2181ae26f7e
::endgroup::
::group::@inox-tools/runtime-logger:build
cache hit, suppressing logs c6898eafd769f9f7
::endgroup::
::group::@inox-tools/request-nanostores:build
cache hit, suppressing logs d7b322c93ed6bf79
::endgroup::
::group::@inox-tools/astro-when:build
cache miss, executing c26d50588016c7b9

> @inox-tools/[email protected] build /home/runner/work/inox-tools/inox-tools/packages/astro-when
> tsup

�[34mCLI�[39m Building entry: src/index.ts
�[34mCLI�[39m Using tsconfig: tsconfig.json
�[34mCLI�[39m tsup v8.2.4
�[34mCLI�[39m Using tsup config: /home/runner/work/inox-tools/inox-tools/packages/astro-when/tsup.config.ts
�[34mCLI�[39m Target: node18
�[34mCLI�[39m Cleaning output folder
�[34mESM�[39m Build start
�[32mESM�[39m �[1mdist/index.js     �[22m�[32m2.65 KB�[39m
�[32mESM�[39m �[1mdist/index.js.map �[22m�[32m4.66 KB�[39m
�[32mESM�[39m ⚡️ Build success in 78ms
�[34mDTS�[39m Build start
�[32mDTS�[39m ⚡️ Build success in 1900ms
�[32mDTS�[39m �[1mdist/index.d.ts �[22m�[32m186.00 B�[39m
::endgroup::

 Tasks:    14 successful, 14 total
Cached:    13 cached, 14 total
  Time:    3.396s 

Copy link
Collaborator

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should you use addDts if injectTypes is not supported + update docs if needed?

@Fryuni
Copy link
Owner Author

Fryuni commented Sep 5, 2024

addDts can only be used on astro:config:setup and I'll only know if the injectTypes will be available on the astro:config:done. I might make something about this separately

@Fryuni Fryuni merged commit 485df2c into main Sep 5, 2024
20 checks passed
@Fryuni Fryuni deleted the feat/astro-when/type-linking branch September 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[astro-when] Type Errors for some gosh darn reason
2 participants