-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New test package #158
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the PR but I think there's work done by Alex to have astro/test-utils
. I'm afraid this package would be made useless by his work. Let's double check first!
There is ongoing conversation about having this in the Astro core repo to be published under I'll still need this to test existing and future Inox Tools packages until that lands on Astro. If/when that happens, this package can be deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, I left a couple of suggestions to improve clarity. Let me know what you think 😁
Co-authored-by: Paul Valladares <[email protected]> Signed-off-by: Luiz Ferraz <[email protected]>
I will merge this to proceed with testing everything on Inox Tools. We can always come back to it as others develop opinions about it. |
Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Paul Valladares <[email protected]> Signed-off-by: Luiz Ferraz <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Paul Valladares <[email protected]> Signed-off-by: Luiz Ferraz <[email protected]>
This new package is essentially the test-utils, the test adapter, and the node module validation plugin from the Astro core repo, but with the following modifications: