-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] release #177
[ci] release #177
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request includes the removal of global modifications related to the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (17)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (15)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
packages/modular-station/CHANGELOG.md (2)
8-8
: Fix typo in changelog entryThere's a typo in the word "direcly" which should be "directly".
-- aa73961: Fixes duplicated initialization of API module when used transitively by integrations and direcly by the user project ++ aa73961: Fixes duplicated initialization of API module when used transitively by integrations and directly by the user project
7-8
: Consider adding more context to the changelog entriesWhile the changes are documented, it would be helpful to provide more context:
- For the debug package options removal: Why was this change made? Are there any migration steps users need to take?
- For the API module initialization fix: What were the symptoms of the issue? How does this affect existing implementations?
This additional information would help users understand the impact of these changes better.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (17)
.changeset/rich-wolves-collect.md
(0 hunks).changeset/wicked-parrots-trade.md
(0 hunks)packages/aik-mod/CHANGELOG.md
(1 hunks)packages/aik-mod/package.json
(1 hunks)packages/astro-tests/CHANGELOG.md
(1 hunks)packages/astro-tests/package.json
(1 hunks)packages/content-utils/CHANGELOG.md
(1 hunks)packages/content-utils/package.json
(1 hunks)packages/inline-mod/CHANGELOG.md
(1 hunks)packages/inline-mod/package.json
(1 hunks)packages/modular-station/CHANGELOG.md
(1 hunks)packages/modular-station/package.json
(1 hunks)packages/modular-station/src/internal/debug.ts
(1 hunks)packages/portal-gun/CHANGELOG.md
(1 hunks)packages/portal-gun/package.json
(1 hunks)packages/runtime-logger/CHANGELOG.md
(1 hunks)packages/runtime-logger/package.json
(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/rich-wolves-collect.md
- .changeset/wicked-parrots-trade.md
✅ Files skipped from review due to trivial changes (13)
- packages/aik-mod/CHANGELOG.md
- packages/aik-mod/package.json
- packages/astro-tests/CHANGELOG.md
- packages/astro-tests/package.json
- packages/content-utils/CHANGELOG.md
- packages/content-utils/package.json
- packages/inline-mod/package.json
- packages/modular-station/package.json
- packages/modular-station/src/internal/debug.ts
- packages/portal-gun/CHANGELOG.md
- packages/portal-gun/package.json
- packages/runtime-logger/CHANGELOG.md
- packages/runtime-logger/package.json
🔇 Additional comments (1)
packages/inline-mod/CHANGELOG.md (1)
3-7
: LGTM! Changelog entry is consistent with PR objectives.
The changelog entry for version 1.5.3 correctly documents the removal of global debug package options, which aligns with similar changes in other packages mentioned in the PR objectives.
Let's verify the consistency of this change across other packages:
✅ Verification successful
Let me verify the package structure and changelog locations first.
Version and changelog entries are consistent across packages
The changelog entry for removing global debug package options (commit aa73961) is consistently documented across multiple packages:
- packages/inline-mod/CHANGELOG.md (v1.5.3)
- packages/modular-station/CHANGELOG.md (v0.3.4)
- packages/astro-tests/CHANGELOG.md (v0.1.6)
The package.json version (1.5.3) matches the changelog version, confirming proper version bumping.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that similar changelog entries exist in related packages
# Expected: Find similar entries about removing debug package options
# Search for similar changelog entries in other packages
rg -l "Remove global change to \`debug\` package options" "packages/*/CHANGELOG.md"
# Verify the version bump is consistent with the changeset
gh api graphql -f query='
query {
repository(owner: "Fryuni", name: "inox-tools") {
object(expression: "HEAD:packages/inline-mod/package.json") {
... on Blob {
text
}
}
}
}' | jq -r '.data.repository.object.text' | jq '.version'
Length of output: 414
Script:
#!/bin/bash
# Check repository structure and find changelog files
fd -t f "CHANGELOG.md"
# Check if there are other packages with similar changes
rg -A 5 -B 5 "debug" "CHANGELOG.md"
Length of output: 1043
Script:
#!/bin/bash
# Search for debug-related changes in all changelog files
rg -A 5 -B 5 "debug" packages/*/CHANGELOG.md
# Get the version from package.json to verify version mismatch
cat packages/inline-mod/package.json | jq '.version'
Length of output: 5464
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/modular-station/CHANGELOG.md (1)
3-9
: Fix typo in changelog entryThe changelog entries look good and properly document the changes. However, there's a typo in line 8: "direcly" should be "directly".
- - aa73961: Fixes duplicated initialization of API module when used transitively by integrations and direcly by the user project + - aa73961: Fixes duplicated initialization of API module when used transitively by integrations and directly by the user project
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (17)
.changeset/rich-wolves-collect.md
(0 hunks).changeset/wicked-parrots-trade.md
(0 hunks)packages/aik-mod/CHANGELOG.md
(1 hunks)packages/aik-mod/package.json
(1 hunks)packages/astro-tests/CHANGELOG.md
(1 hunks)packages/astro-tests/package.json
(1 hunks)packages/content-utils/CHANGELOG.md
(1 hunks)packages/content-utils/package.json
(1 hunks)packages/inline-mod/CHANGELOG.md
(1 hunks)packages/inline-mod/package.json
(1 hunks)packages/modular-station/CHANGELOG.md
(1 hunks)packages/modular-station/package.json
(1 hunks)packages/modular-station/src/internal/debug.ts
(1 hunks)packages/portal-gun/CHANGELOG.md
(1 hunks)packages/portal-gun/package.json
(1 hunks)packages/runtime-logger/CHANGELOG.md
(1 hunks)packages/runtime-logger/package.json
(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/rich-wolves-collect.md
- .changeset/wicked-parrots-trade.md
✅ Files skipped from review due to trivial changes (13)
- packages/aik-mod/CHANGELOG.md
- packages/aik-mod/package.json
- packages/astro-tests/package.json
- packages/content-utils/CHANGELOG.md
- packages/content-utils/package.json
- packages/inline-mod/CHANGELOG.md
- packages/inline-mod/package.json
- packages/modular-station/package.json
- packages/modular-station/src/internal/debug.ts
- packages/portal-gun/CHANGELOG.md
- packages/portal-gun/package.json
- packages/runtime-logger/CHANGELOG.md
- packages/runtime-logger/package.json
🔇 Additional comments (3)
packages/astro-tests/CHANGELOG.md (2)
3-7
: LGTM! Changelog entry follows the conventional format.
The new version entry is well-structured with proper categorization as a patch change and includes the relevant commit hash.
7-7
: Verify debug functionality after removing global options.
Since debug logging was initially added in v0.1.1 and this change removes global options, ensure that debugging capabilities are still accessible where needed, just configured locally instead.
✅ Verification successful
Based on the shell script results, I can now generate the final response:
Debug functionality remains intact with local configuration
The codebase shows proper local debug configuration:
- Debug is correctly imported and configured in
internal/log.ts
using the 'inox-tools:astro-tests' namespace - Local debug instances are created via
getDebug()
with specific names (e.g., 'testAdapter', 'fixture') - Debug calls are actively used throughout the codebase for logging important operations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for remaining debug-related code and configuration
# to ensure debugging capabilities are maintained but configured locally
# Look for debug-related imports and usage
rg -A 3 "debug|Debug" packages/astro-tests/
# Look for debug configuration patterns
ast-grep --pattern 'debug($$$)' packages/astro-tests/
Length of output: 14492
packages/modular-station/CHANGELOG.md (1)
7-7
: Verify the impact of removing debug options
The removal of global debug package options is also reflected in other packages (@inox-tools/astro-tests and @inox-tools/inline-mod). Let's verify there are no remaining global debug configurations.
✅ Verification successful
No remaining global debug configurations found
Based on the comprehensive analysis of the codebase:
- All debug imports are properly scoped to their respective packages using namespaced debuggers (e.g., 'inox-tools:package-name')
- No global debug configurations (enable/disable/set/options) were found in any files
- Package.json files only contain debug as a dependency, with no global configurations
- The removal of global debug options has been properly implemented across all packages
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Search for any remaining global debug configurations across the codebase
# Search for debug configuration patterns
echo "Searching for debug configurations..."
rg -i "debug\.(enable|disable|set|options)"
# Search for debug package imports
echo "Searching for debug package imports..."
rg "^import.*debug['\"]"
rg "require.*debug['\"]"
Length of output: 1129
Script:
#!/bin/bash
# Let's check the actual usage of debug configurations in these files
# First, let's check for any global debug configurations in the files that import debug
echo "Checking debug configuration in files..."
for file in $(rg -l "^import.*debug['\"]"); do
echo "=== $file ==="
rg -A 5 "^import.*debug['\"]" "$file"
done
# Also check for any debug-related configuration in package.json files
echo -e "\nChecking package.json files for debug configurations..."
fd "package.json" --exec rg -l "debug" {}
Length of output: 5567
Script:
#!/bin/bash
# Let's check the package.json files for any global debug configurations
echo "Checking debug configurations in package.json files..."
for file in $(fd package.json); do
echo "=== $file ==="
cat "$file" | grep -A 5 -B 5 "debug"
done
# Let's also check for any debug.enable or debug.disable calls in the test files
echo -e "\nChecking test files for debug configurations..."
fd "test" -e ts -e js --exec rg "debug\.(enable|disable|set|options)" {}
Length of output: 12561
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/modular-station/CHANGELOG.md (1)
8-8
: Fix typo in changelog entryThere's a typo in the word "direcly" which should be "directly".
-Fixes duplicated initialization of API module when used transitively by integrations and direcly by the user project +Fixes duplicated initialization of API module when used transitively by integrations and directly by the user project
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (17)
.changeset/rich-wolves-collect.md
(0 hunks).changeset/wicked-parrots-trade.md
(0 hunks)packages/aik-mod/CHANGELOG.md
(1 hunks)packages/aik-mod/package.json
(1 hunks)packages/astro-tests/CHANGELOG.md
(1 hunks)packages/astro-tests/package.json
(1 hunks)packages/content-utils/CHANGELOG.md
(1 hunks)packages/content-utils/package.json
(1 hunks)packages/inline-mod/CHANGELOG.md
(1 hunks)packages/inline-mod/package.json
(1 hunks)packages/modular-station/CHANGELOG.md
(1 hunks)packages/modular-station/package.json
(1 hunks)packages/modular-station/src/internal/debug.ts
(1 hunks)packages/portal-gun/CHANGELOG.md
(1 hunks)packages/portal-gun/package.json
(1 hunks)packages/runtime-logger/CHANGELOG.md
(1 hunks)packages/runtime-logger/package.json
(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/rich-wolves-collect.md
- .changeset/wicked-parrots-trade.md
✅ Files skipped from review due to trivial changes (12)
- packages/aik-mod/CHANGELOG.md
- packages/aik-mod/package.json
- packages/astro-tests/package.json
- packages/content-utils/CHANGELOG.md
- packages/content-utils/package.json
- packages/inline-mod/package.json
- packages/modular-station/package.json
- packages/modular-station/src/internal/debug.ts
- packages/portal-gun/CHANGELOG.md
- packages/portal-gun/package.json
- packages/runtime-logger/CHANGELOG.md
- packages/runtime-logger/package.json
🔇 Additional comments (4)
packages/astro-tests/CHANGELOG.md (2)
3-8
: LGTM! Changelog entry follows the correct format.
The new version entry properly documents the removal of global debug options as a patch change, which is appropriate for this type of modification.
7-7
: Verify the debug options removal implementation.
Since version 0.1.1 introduced debug logging (commit 81db094), let's verify that its removal is properly implemented.
packages/modular-station/CHANGELOG.md (1)
Line range hint 1-24
: Well-structured changelog entries
The changelog follows best practices with clear versioning, proper categorization of changes, and consistent formatting. The entries provide good traceability with commit references and clear descriptions of changes.
packages/inline-mod/CHANGELOG.md (1)
3-7
: LGTM! Changelog entry is accurate and well-formatted.
The changelog entry correctly documents the removal of global debug settings as a patch change, which aligns with the PR objectives.
Let's verify the referenced commit:
3c7c6f2
to
50af19d
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@inox-tools/[email protected]
Patch Changes
@inox-tools/[email protected]
Patch Changes
debug
package options@inox-tools/[email protected]
Patch Changes
@inox-tools/[email protected]
Patch Changes
debug
package options@inox-tools/[email protected]
Patch Changes
debug
package options@inox-tools/[email protected]
Patch Changes
@inox-tools/[email protected]
Patch Changes
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
@inox-tools/modular-station
.@inox-tools/runtime-logger
.Dependency Updates
@inox-tools/inline-mod
to version 1.5.3@inox-tools/modular-station
to version 0.3.4@inox-tools/runtime-logger
to version 0.3.5@inox-tools/content-utils
to version 0.7.4@inox-tools/portal-gun
to version 0.1.1Changelog Updates