Make the game over music loop for pico's explosion the default #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbnormalPoof
added
type: minor bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
FunkinCrew/Funkin#2900
Briefly describe the issue(s) fixed.
There's a fade in on the music used for pico's explosion game over, but it's not swapped out for the default game over music that doesn't have it, leading to it fading in again when it repeats.
Include any relevant screenshots or videos.
2hot.gameover.fade.in.bug.mp4
2025-01-29.22-57-23.1.mp4
Note that I implemented this fix: #97 locally to be able to show off the death properly, though I made sure that it wasn't included in the commit.