Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply colorShader once instead of every frame #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AbnormalPoof
Copy link
Collaborator

@AbnormalPoof AbnormalPoof commented Oct 29, 2024

Week 5 Erect's stage has this:

override function addCharacter(character:BaseCharacter, charType:CharacterType):Void {
	// Apply the shader automatically to each character as it gets added.
	super.addCharacter(character, charType);
	trace('Applied stage shader to ' + character.characterName);
	character.shader = colorShader;
}

This applies the shader when a character is added instead of only BF, GF, and Dad. So pretty much any character type can have the shader.
I updated the rest of the stage scripts to do something similar instead of applying the shader every frame.

I tested the stages and everything works fine.

@AbnormalPoof AbnormalPoof changed the title Apply colorShader using addCharacter Apply colorShader using addCharacter() Oct 29, 2024
@AbnormalPoof AbnormalPoof changed the title Apply colorShader using addCharacter() Apply colorShader once instead of every frame Nov 3, 2024
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. status: pending triage The bug or PR has not been reviewed yet. size: medium A medium pull request with 100 or fewer changes type: optimization Involves a performance issue or a bug which causes lag. and removed type: minor bug Involves a minor bug or issue. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: medium A medium pull request with 100 or fewer changes status: pending triage The bug or PR has not been reviewed yet. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant