Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

199 - Order of options in form field #280

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

zaalbarxx
Copy link
Contributor

  • fixed issue with options order not being preserved for form_field object

@zaalbarxx zaalbarxx changed the title Fix 199 199 - Order of options in form field May 31, 2024
@zaalbarxx
Copy link
Contributor Author

It is worth noting that it can be potentially a breaking change if some configuration mistakenly contains two of the same options, although it is possible that this is additionally validated at the API call level and therefore will instead just throw error during apply.

Copy link
Contributor

@mmanes mmanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @zaalbarxx! I just have one comment.

fusionauth/helpers.go Outdated Show resolved Hide resolved
removed debug statement
@zaalbarxx
Copy link
Contributor Author

zaalbarxx commented Jun 14, 2024

@mmanes Also created commit which fixes #281

@mmanes
Copy link
Contributor

mmanes commented Jun 14, 2024

@mmanes Also created commit which fixes #281

Thanks for adding that @zaalbarxx! Do you still need to complete testing on this, or is it ready to go?

@zaalbarxx
Copy link
Contributor Author

I'll test it again during the weekend and let you know. :)

@zaalbarxx
Copy link
Contributor Author

I can confirm @mmanes that it looks like it works correctly. So merging this would close #281 also.

@mmanes mmanes merged commit aee337f into FusionAuth:main Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants