Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week8_Assignment_1 #17

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Week8_Assignment_1 #17

merged 1 commit into from
Jan 17, 2025

Conversation

taeh-kim
Copy link
Collaborator

๐Ÿ“ฅ AOS Pull Request ์ œ์ถœ

๐Ÿ“Œ ๊ณผ์ œ ์ œ๋ชฉ : Week8 Assignment

๊ณผ์ œ ๊ฐœ์š” ๋ฐ ๋‚ด์šฉ์„ ๊ฐ„๋‹จํžˆ ์ ์–ด์ฃผ์„ธ์š”.
newsapi์‚ฌ์šฉํ•˜์—ฌ ๋‰ด์Šค ๋ฐ์ดํ„ฐ ๊ฐ€์ ธ์˜ค๊ธฐ

โœ… ๊ตฌํ˜„ ์‚ฌํ•ญ

๊ตฌํ˜„ํ•œ ๊ธฐ๋Šฅ ๋ชฉ๋ก์„ ์ ์–ด์ฃผ์„ธ์š”.
๊ตฌํ˜„ : ๊ธฐ์‚ฌ ์ œ๋ชฉ, ๋‚ด์šฉ ๊ฐ€์ ธ์˜ค๊ธฐ
๋ฏธ๊ตฌํ˜„ : ์‚ฌ์ง„(asyncimage), ์ƒˆ๋กœ๊ณ ์นจ

โš™๏ธ ๊ธฐ๋Šฅ ์‹œ์—ฐ

๊ณผ์ œ ๊ตฌํ˜„์„ ํ™•์ธํ•  ์ˆ˜ ์žˆ๋Š” ์Šคํฌ๋ฆฐ์ƒท ๋˜๋Š” ์˜์ƒ์„ ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”.
week8

@taeh-kim taeh-kim added ๊ณผ์ œ ์ œ์ถœ Good for newcomers ํƒœํ›ˆ Extra attention is needed labels Jan 14, 2025
a-honey
a-honey reviewed Jan 15, 2025
View reviewed changes
...8_Assignment/Week8_Assignment/app/src/main/java/com/example/week8_assignment/MainActivity.kt
Text(
text = article.description ?: "Empty",
maxLines = 2,
overflow = TextOverflow.Ellipsis // ๋’ค์— ...์œผ๋กœ ํ‘œํ˜„
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextOverflow.Ellipsis ํ™œ์šฉํ•˜์‹ ๊ฑฐ ์ข‹๋„ค์š” ๐Ÿ‘

GwonDongHyeon21
GwonDongHyeon21 reviewed Jan 17, 2025
View reviewed changes
...8_Assignment/Week8_Assignment/app/src/main/java/com/example/week8_assignment/MainActivity.kt
fun GetNews() {
viewModelScope.launch(Dispatchers.IO) { //
try {
val response = newsApiService.getTopHeadlines("d5625a23b0d647b681aac61b6fad718e")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API key๋Š” ๋ณด์•ˆ์ƒ ๊ฐ€๋ฆฌ๋Š”๊ฒŒ ์ข‹์„๊ฑฐ ๊ฐ™์•„์š”

...8_Assignment/Week8_Assignment/app/src/main/java/com/example/week8_assignment/MainActivity.kt
Text(
text = article.description ?: "Empty",
maxLines = 2,
overflow = TextOverflow.Ellipsis // ๋’ค์— ...์œผ๋กœ ํ‘œํ˜„
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextOverflow ํ™œ์šฉํ•˜์‹ ๊ฑฐ ์ข‹์€๊ฑฐ ๊ฐ™์•„์š”๐Ÿ‘

@GwonDongHyeon21 GwonDongHyeon21 merged commit 9edddda into GDG-on-Campus-KHU:main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GwonDongHyeon21 GwonDongHyeon21 GwonDongHyeon21 left review comments

@a-honey a-honey a-honey left review comments

Assignees
No one assigned
Labels
๊ณผ์ œ ์ œ์ถœ Good for newcomers ํƒœํ›ˆ Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taeh-kim @a-honey @GwonDongHyeon21