New extension: OfflineTimeTracker

[github-actions]

Description

Calculation of the time passed (in and out of the game).
By LazyPanda(Mahan-ashrafi)

How to use the extension

for calculating the time between 2 points in time.
no matter the game/app is open or closed , if you have a timestamp saved when the game/app is open it will keep track of the time passed

Checklist

• I've followed all of the best practices.
• I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
• I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Reviewed

Example file

ExampleProject.zip

Extension file

OfflineTimeTrackerExtension.zip

[VegeTato]

Hello @Mahan-Ashrafi 👋 thank you for submitting this amazing extension ! ❤️
I noticed few things in the extension that need to be fixed:
1- Please follow the best extension practices, for example:
Your storage name "timestamp" must be __TimeStamp.timestamp same thing apply to timers names.
Your variable name Loadedname should be __TimeStamp.Loadedname same thing apply to all variables.
2- You are using log message action in the extension, this is not required for the extension to work, so it's better to delete them.
3- If possible, please add comments explaining what the event do, so if any user wants to take a look at the extension events, can understand what's going around.
4- Use PascalCase in your parameters names, for example:
parameter name must be Name, same thing apply for the parameters first and second.

Fix this issues and let me know, so I can review the extension 👍

[Mahan-Ashrafi]

Hello @Mahan-Ashrafi 👋 thank you for submitting this amazing extension ! ❤️ I noticed few things in the extension that need to be fixed: 1- Please follow the best extension practices, for example: Your storage name "timestamp" must be __TimeStamp.timestamp same thing apply to timers names. Your variable name Loadedname should be __TimeStamp.Loadedname same thing apply to all variables. 2- You are using log message action in the extension, this is not required for the extension to work, so it's better to delete them. 3- If possible, please add comments explaining what the event do, so if any user wants to take a look at the extension events, can understand what's going around. 4- Use PascalCase in your parameters names, for example: parameter name must be Name, same thing apply for the parameters first and second.

Fix this issues and let me know, so I can review the extension 👍

Thx ill fix it in a minute

[Mahan-Ashrafi]

@VegeTato Here You go !
updated the description , icon ( to better suit the title )
if it needs anything else alert me

[D8H]

Your storage name "timestamp" must be __TimeStamp.timestamp same thing apply to timers names.

Actually, it would just be __TimeStamp. It wouldn't make much sense to create several storages for an extension.

3- If possible, please add comments explaining what the event do, so if any user wants to take a look at the extension events, can understand what's going around.

Where do you think a comment is needed? This extension only use storage actions and a subtraction, this looks straightforward to me.

[Mahan-Ashrafi]

Your storage name "timestamp" must be __TimeStamp.timestamp same thing apply to timers names.

Actually, it would just be __TimeStamp. It wouldn't make much sense to create several storages for an extension.

3- If possible, please add comments explaining what the event do, so if any user wants to take a look at the extension events, can understand what's going around.

Where do you think a comment is needed? This extension only use storage actions and a subtraction, this looks straightforward to me.

I added comments to the extension code
Is that needed ?
And i already uploaded the update

[D8H]

This is paraphrasing the action description. It won't help readers.
You can remove all of them, sorry for the burden.

[D8H]

Your storage name "timestamp" must be __TimeStamp.timestamp same thing apply to timers names.

Actually, it would just be __TimeStamp. It wouldn't make much sense to create several storages for an extension.

Your extension name is TimeStampManager so the storage name should even be __TimeStampManagerExtension. "Timestamp" is only one word, so the "S" should be lower case.
I think the extension name is a bit vague and technical. Users may not understand it. What do you think about "OfflineTimeChecker" or something like this? The idea is to find a name that explains the main feature rather than how it's implemented.

[Mahan-Ashrafi]

Maybe OfflineTimeTracker
I like it to be timestamp for people to learn some technical terms
This extension will be used by advanced users mostly

[D8H]

Maybe OfflineTimeTracker I like it to be timestamp for people to learn some technical terms This extension will be used by advanced users mostly

Indeed, "OfflineTimeTracker" is great. Yes, you can still use "timestamp" in the actions.

[Mahan-Ashrafi]

Maybe OfflineTimeTracker I like it to be timestamp for people to learn some technical terms This extension will be used by advanced users mostly

Indeed, "OfflineTimeTracker" is great. Yes, you can still use "timestamp" in the actions.

Ohh i can keep timestamp 😅
Ok ill be back with the update

[Mahan-Ashrafi]

@VegeTato @D8H Done !

[D8H]

Please attach the new version of the example. It's the example that is used to do the review.

[Mahan-Ashrafi]

Please attach the new version of the example. It's the example that is used to do the review.

I just checked I did
You mean create a new example ?

[D8H]

Please attach the new version of the example. It's the example that is used to do the review.

I just checked I did You mean create a new example ?

I can't find it. I mean the same example but which uses the new extension version.

[Mahan-Ashrafi]

Please attach the new version of the example. It's the example that is used to do the review.

I just checked I did You mean create a new example ?

I can't find it. I mean the same example but which uses the new extension version.

https://github.com/GDevelopApp/GDevelop-extensions/files/14731017/ExampleProject.zip

Its in this page already @D8H

[D8H]

https://github.com/GDevelopApp/GDevelop-extensions/files/14731017/ExampleProject.zip

Its in this page already @D8H

This is the link to the example that uses the 1st version of the extension, right?

Edit: sorry, it seems the bot updated the links.

[D8H]

• Both PR

  • I think the value should not be rounded.
    • It's easy for extension users to round it if they need to, but impossible to "unround" it.
  • What do you think about automatically saving the timestamp every minute by default?
    • onScenePreEvents can be used for this.
    • An action could allow to change the frequency to 1 per second or 1 per hour.

• This PR

  • The timestamp name is to handle several users?
    • If the save is done automatically, an action could allow to change the name to use to keep this feature

• NEW EXTENSION - Offline Time #1211

  • @TheGemDev uses JavaScript but it doesn't seem necessary. It's better to keep using events.
  • It has an expression that allows to get the offline time in days, hours, minutes or seconds.
    • I think it make sense to use different units
    • An expression with the unit in parameter is not practical, it's better to have 4 expressions directly.
    • A condition could be useful, the unit could be a parameter in this case.

[Mahan-Ashrafi]

• Both PR

  • I think the value should not be rounded.
    • It's easy for extension users to round it if they need to, but impossible to "unround" it.
  • What do you think about automatically saving the timestamp every minute by default?
    • onScenePreEvents can be used for this.
    • An action could allow to change the frequency to 1 per second or 1 per hour.

• This PR

  • The timestamp name is to handle several users?
    • If the save is done automatically, an action could allow to change the name to use to keep this feature

• NEW EXTENSION - Offline Time #1211

  • @TheGemDev uses JavaScript but it doesn't seem necessary. It's better to keep using events.
  • It has an expression that allows to get the offline time in days, hours, minutes or seconds.
    • I think it make sense to use different units
  • An expression with the unit in parameter is not practical, it's better to have 4 expressions directly.
  • A condition could be useful, the unit could be a parameter in this case.

Ok ill delete the rounding part as it removes the precision.

So whats the purpose of saving a timestamp then if you want to have autosave ?
Its better to save it whenever the user wants it to.

So you mean add an action to change a timestamps name?

[D8H]

So whats the purpose of saving a timestamp then if you want to have autosave ?

My point is that users don't know when they should save them as there is no way to know when the game is closed and if they want to compare timestamps during the same sessions they don't need an extension and should probably use timers.
So, the extension should do it automatically at a given interval.

[Mahan-Ashrafi]

So whats the purpose of saving a timestamp then if you want to have autosave ?

My point is that users don't know when they should save them as there is no way to know when the game is closed and if they want to compare timestamps during the same sessions they don't need an extension and should probably use timers.
So, the extension should do it automatically at a given interval.

Timestamps make it easier to manage and track time in and out of the game.
So what im going to do is keep my stuff as they are and add another expression to auto save with the given interval.
Auto saving timestamps mostly have no use case and is not the main idea of the extension.

[TheGemDev]

Auto saving timestamps mostly have no use case and is not the main idea of the extension.

i think auto saving is essential.