-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Community] [Point and Orbit] Add the ability to point towards an angle (useful for gamepads) #1281
Conversation
"shortDescription": "Point an object toward a position or angle while orbiting that object around a position.", | ||
"version": "1.1.0", | ||
"description": [ | ||
"# User can", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wiki uses #
for page title. Titles in description should be ##
, but "User can" will look a bit silly in a summary. I think it's better to not use titles in descriptions.
Also, either use "you can" or "It allows" instead of "user can". You won't see "user" anywhere in the wiki (if you do, please report it).
Edit: I realized that you are not the initial author of the extension. It's not mandatory to change it.
Why would someone make the object rotate at a given speed when it moves instantly. I guess it would look weird, wouldn't it? |
Also update wording.
Good point! I copied your math from the Turret extension and got this working. Thanks for catching this oversight! Err... do you think we should merge this into the Turret extension? GDevelop_KjFscSGBcb.mp4 |
Sorry, my point was more about removing the speed parameter. To me, this extension purpose is just to squash "put around" and "change angle" to avoid to fill the direction 2 times. I'm not prod of what I've done for the Turret extension. It will need some complete rework. |
@D8H do you mind if I keep this "speed" feature? I think it is a fun and easy mechanism that could be useful in games. Any other thoughts or comments before I merge this? |
I think it's over-complexifying the extension for maybe no value. What uses-cases do you see for it? |
ok... nice discussing with you too... 😕 Did you miss my last message? |
"description": "Pointing speed (in deg/second)", | ||
"longDescription": "Set to 0 for an immediate pointing.", | ||
"name": "PointSpeed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this handled by your change?
GDevelop_67OhgpPNlW.mp4