Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reviewed] [Two choices dialog box] Simplify the events #1488

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[Reviewed] [Two choices dialog box] Simplify the events #1488

merged 1 commit into from
Jan 10, 2025

Conversation

D8H
Copy link
Contributor

@D8H D8H commented Jan 9, 2025 •
edited
Loading

Changes

  • Simplify the events
  • Hide instructions and properties about button id because users can't know what it means.
    • if the feature is ask, it should probably use user-defined button labels.

Demo

@D8H D8H added 🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels Jan 9, 2025
@D8H D8H self-assigned this Jan 9, 2025
@D8H D8H requested a review from a team as a code owner January 9, 2025 17:54
@Bouh Bouh merged commit e2db428 into main Jan 10, 2025
4 checks passed
@Bouh Bouh deleted the dialog-box-simplify branch January 10, 2025 11:01
@Bouh
Copy link
Contributor

Bouh commented Jan 10, 2025 •
edited
Loading

doStepPostsEvents function is indeed simplier now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bouh Bouh Bouh approved these changes

Assignees

@D8H D8H

Labels
🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
Extensions review
Status: Added to GDevelop
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D8H @Bouh