Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wdboggs/outer meta component datetime compatibility 3357 #3368

Open
wants to merge 16 commits into
base: release/MAPL-v3
Choose a base branch
from

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

As explained in #3357, the timestep and reference time for the user component, and therefore all the user alarms, must be compatible with the timestep and reference time for the OuterMetaComponent. Because the reference times may not be the same, it is insufficient to check the timesteps. This PR checks all user alarms, as determined by the user timestep and reference time, are compatible with the timestep and reference time of the OuterMetaComponent. It closes #3357.

Related Issue

#3357

@darianboggs darianboggs added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Jan 28, 2025
@darianboggs darianboggs requested a review from tclune January 28, 2025 15:01
@darianboggs darianboggs self-assigned this Jan 28, 2025
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

@darianboggs darianboggs marked this pull request as ready for review January 30, 2025 16:17
@darianboggs darianboggs requested a review from a team as a code owner January 30, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants