-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wdboggs/outer meta component datetime compatibility 3357 #3368
Open
darianboggs
wants to merge
16
commits into
release/MAPL-v3
Choose a base branch
from
feature/wdboggs/outer_meta_component_datetime_compatibility_3357
base: release/MAPL-v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/wdboggs/outer meta component datetime compatibility 3357 #3368
darianboggs
wants to merge
16
commits into
release/MAPL-v3
from
feature/wdboggs/outer_meta_component_datetime_compatibility_3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darianboggs
added
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
📈 MAPL3
MAPL 3 Related
labels
Jan 28, 2025
…ent_datetime_compatibility_3357
tclune
reviewed
Jan 28, 2025
tclune
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine.
…er_meta_component_datetime_compatibility_3357' into feature/wdboggs/outer_meta_component_datetime_compatibility_3357
…ent_datetime_compatibility_3357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests
)Description
As explained in #3357, the timestep and reference time for the user component, and therefore all the user alarms, must be compatible with the timestep and reference time for the OuterMetaComponent. Because the reference times may not be the same, it is insufficient to check the timesteps. This PR checks all user alarms, as determined by the user timestep and reference time, are compatible with the timestep and reference time of the OuterMetaComponent. It closes #3357.
Related Issue
#3357