Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization and further Code Cleanup #36

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jasperschroeder
Copy link
Collaborator

This Pull request encompasses three major topics:

  1. Modularization of widgets for notebooks
  2. Passing period and scenario as function parameters
  3. Further Code Cleanup

1 Modularization of widgets for notebooks
In order to modularize code and to avoid duplication of code blocks, I created common and notebook-specific helper files that contain code to create the widgets. Storing these in dedicated files instead of repeating code across multiple notebooks will help to make code more maintainable. (This goes into direction of modularization as raised in Issue 35.

2 Passing period and scenario as function parameters
I noticed that period and scenario variables were not yet passed as function parameters in the corresponding function definitions and calls. Thus, I modified the code so that these are now passed as function parameters.

3 Further Code Cleanup
I further cleaned up the code, most notable is that I removed the "from common import *" statement in runAnalysis as this behavior can clutter the namespace and makes it harder to track if, e.g., libraries are imported but not used. Other items include moving the URL for the world pop into the common file (to align with the rest_api_url parameter).

…ort star and passing period and scenario as parameters to functions
@matamadio matamadio merged commit e669f0c into dev_push Sep 4, 2024
@jasperschroeder jasperschroeder deleted the js/20240901-code_changes branch September 6, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants