-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more class factories #149
Merged
Merged
Changes from 18 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0535e9f
removed one order of magnitude precision required
josephdviviano 7753041
merge conflicts
josephdviviano f7a562e
replaced State method call with Env method call
josephdviviano 742bfb2
replaced State method call with Env method call, and removed is_tenso…
josephdviviano f545167
replaced State method call with Env method call
josephdviviano f945b39
switch name of backward/forward step, and replaced State method call …
josephdviviano 2a51704
removed States/Actions class definition, added the appropriate args t…
josephdviviano cdd425c
moved environment to Gym
josephdviviano 6ae846b
renamed maskless_?_step functions, and made the generic step/backward…
josephdviviano a09c9a5
removed comment
josephdviviano 93f6a65
States methods moved to Env methods, also, name change for step
josephdviviano 2ab5885
changes to the handling of forward / backward masks. in addition, mak…
josephdviviano bfd6bbf
method renaming
josephdviviano d6d30fe
docs update (TOOD: this might need a full rework)
josephdviviano 25b7527
changes to support new API
josephdviviano f12cbec
tweaks (TODO: fix in follow up PR)
josephdviviano cdffab1
black / isort
josephdviviano 3b756a5
cleanup
josephdviviano c98f423
gradient clipping added back in
6af395f
renaming make_States_class to follow pep
josephdviviano 6c0d8aa
updated documentation
josephdviviano 364e52d
rename methods
josephdviviano 8d8a4c1
rename method
josephdviviano ebf0db2
deps
josephdviviano 71e6603
requirements
josephdviviano c393014
deps
josephdviviano 3cb9914
merge
josephdviviano b85f1eb
merged
josephdviviano ad80e7e
update
josephdviviano ae3fa2e
update
josephdviviano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change 👌